[Android] Fix adb realpath command failure.

build/android/pylib/android_commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides an interface to communicate with the device via the adb command.
 
 Assumes adb binary is currently on system path.
 """
 # pylint: disable-all
 
@@ skipping 1004 matching lines @@
     Returns:
       A list of tuples of the form (host_path, device_path) for files whose
       md5sums do not match.
     """
 
     # Md5Sum resolves symbolic links in path names so the calculation of
     # relative path names from its output will need the real path names of the
     # base directories. Having calculated these they are used throughout the
     # function since this makes us less subject to any future changes to Md5Sum.
     real_host_path = os.path.realpath(host_path)
+    self.RunShellCommand('mkdir -p "%s"' % device_path)

[jbudorick, 2014/05/20 01:33:13]

I don't think that GetFilesChanged should be creating directories on the device.
That should be left to PushIfNeeded. I'm also not sure that this fix would work
if the device path was more than one directory deep.

I think you're right that this only triggers on the code path that pushes
individual files in PushIfNeeded. Perhaps we should be creating directories
there? (although that could mean more adb round trips, which we'd like to avoid)

[navabi, 2014/05/20 01:49:15]

I agree that this should not create directories on the device. Can PushIfNeeded
create the directory instead?

[Kibeom Kim (inactive), 2014/05/20 01:58:29]

Done.

     real_device_path = self.RunShellCommand('realpath "%s"' % device_path)[0]
 
     host_hash_tuples, device_hash_tuples = self._RunMd5Sum(
         real_host_path, real_device_path)
 
     if len(host_hash_tuples) > len(device_hash_tuples):
       logging.info('%s files do not exist on the device' %
                    (len(host_hash_tuples) - len(device_hash_tuples)))
 
     host_rel = [(os.path.relpath(os.path.normpath(t.path), real_host_path),
@@ skipping 934 matching lines @@
   """
   def __init__(self, output):
     self._output = output
 
   def write(self, data):
     data = data.replace('\r\r\n', '\n')
     self._output.write(data)
 
   def flush(self):
     self._output.flush()