Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: content/browser/presentation/presentation_service_impl.h

Issue 2938023002: [PresentationService] Improve PresentationServiceImplTest. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/presentation/presentation_service_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/presentation/presentation_service_impl.h
diff --git a/content/browser/presentation/presentation_service_impl.h b/content/browser/presentation/presentation_service_impl.h
index 5b6338713f8412cd877edfa75aeb3be7860b5133..d23ad258e37b62b34621049e5b2c6544982348d0 100644
--- a/content/browser/presentation/presentation_service_impl.h
+++ b/content/browser/presentation/presentation_service_impl.h
@@ -65,40 +65,44 @@ class CONTENT_EXPORT PresentationServiceImpl
const service_manager::BindSourceInfo& source_info,
mojo::InterfaceRequest<blink::mojom::PresentationService> request);
+ // PresentationService implementation.
+ void SetDefaultPresentationUrls(
+ const std::vector<GURL>& presentation_urls) override;
+ void SetClient(blink::mojom::PresentationServiceClientPtr client) override;
+ void ListenForScreenAvailability(const GURL& url) override;
+ void StopListeningForScreenAvailability(const GURL& url) override;
+ void StartPresentation(const std::vector<GURL>& presentation_urls,
+ NewPresentationCallback callback) override;
+ void ReconnectPresentation(const std::vector<GURL>& presentation_urls,
+ const base::Optional<std::string>& presentation_id,
+ NewPresentationCallback callback) override;
+ void CloseConnection(const GURL& presentation_url,
+ const std::string& presentation_id) override;
+ void Terminate(const GURL& presentation_url,
+ const std::string& presentation_id) override;
+ void ListenForConnectionMessages(
+ const PresentationInfo& presentation_info) override;
+ void SetPresentationConnection(
+ const PresentationInfo& presentation_info,
+ blink::mojom::PresentationConnectionPtr controller_connection_ptr,
+ blink::mojom::PresentationConnectionRequest receiver_connection_request)
+ override;
+
private:
friend class PresentationServiceImplTest;
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest, Reset);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest, DidNavigateThisFrame);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- DidNavigateOtherFrame);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest, ThisRenderFrameDeleted);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
OtherRenderFrameDeleted);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest, DelegateFails);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- SetDefaultPresentationUrls);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- SetSameDefaultPresentationUrls);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ClearDefaultPresentationUrls);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ListenForDefaultPresentationStart);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ListenForDefaultPresentationStartAfterSet);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- DefaultPresentationStartReset);
+ ListenForConnectionStateChange);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ReceiveConnectionMessagesAfterReset);
+ ListenForConnectionClose);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
MaxPendingStartPresentationRequests);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
MaxPendingReconnectPresentationRequests);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ListenForConnectionStateChange);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ListenForConnectionClose);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- SetPresentationConnection);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
ReceiverPresentationServiceDelegate);
@@ -159,29 +163,6 @@ class CONTENT_EXPORT PresentationServiceImpl
ControllerPresentationServiceDelegate* controller_delegate,
ReceiverPresentationServiceDelegate* receiver_delegate);
- // PresentationService implementation.
- void SetDefaultPresentationUrls(
- const std::vector<GURL>& presentation_urls) override;
- void SetClient(blink::mojom::PresentationServiceClientPtr client) override;
- void ListenForScreenAvailability(const GURL& url) override;
- void StopListeningForScreenAvailability(const GURL& url) override;
- void StartPresentation(const std::vector<GURL>& presentation_urls,
- NewPresentationCallback callback) override;
- void ReconnectPresentation(const std::vector<GURL>& presentation_urls,
- const base::Optional<std::string>& presentation_id,
- NewPresentationCallback callback) override;
- void CloseConnection(const GURL& presentation_url,
- const std::string& presentation_id) override;
- void Terminate(const GURL& presentation_url,
- const std::string& presentation_id) override;
- void ListenForConnectionMessages(
- const PresentationInfo& presentation_info) override;
- void SetPresentationConnection(
- const PresentationInfo& presentation_info,
- blink::mojom::PresentationConnectionPtr controller_connection_ptr,
- blink::mojom::PresentationConnectionRequest receiver_connection_request)
- override;
-
// Creates a binding between this object and |request|.
void Bind(blink::mojom::PresentationServiceRequest request);
« no previous file with comments | « no previous file | content/browser/presentation/presentation_service_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698