Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2937993002: Revert of Fix stability and data racing issues, coalesce more updates for JumpList (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 class ExclusiveAccessBubbleViews; 56 class ExclusiveAccessBubbleViews;
57 class InfoBarContainerView; 57 class InfoBarContainerView;
58 class LocationBarView; 58 class LocationBarView;
59 class NewBackShortcutBubble; 59 class NewBackShortcutBubble;
60 class StatusBubbleViews; 60 class StatusBubbleViews;
61 class TabStrip; 61 class TabStrip;
62 class ToolbarView; 62 class ToolbarView;
63 class TopContainerView; 63 class TopContainerView;
64 class WebContentsCloseHandler; 64 class WebContentsCloseHandler;
65 65
66 #if defined(OS_WIN)
67 class JumpList;
68 #endif
69
66 namespace extensions { 70 namespace extensions {
67 class ActiveTabPermissionGranter; 71 class ActiveTabPermissionGranter;
68 class Command; 72 class Command;
69 class Extension; 73 class Extension;
70 } 74 }
71 75
72 namespace views { 76 namespace views {
73 class AccessiblePaneView; 77 class AccessiblePaneView;
74 class ExternalFocusTracker; 78 class ExternalFocusTracker;
75 class WebView; 79 class WebView;
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 // Appends to |toolbars| a pointer to each AccessiblePaneView that 490 // Appends to |toolbars| a pointer to each AccessiblePaneView that
487 // can be traversed using F6, in the order they should be traversed. 491 // can be traversed using F6, in the order they should be traversed.
488 void GetAccessiblePanes(std::vector<views::AccessiblePaneView*>* panes); 492 void GetAccessiblePanes(std::vector<views::AccessiblePaneView*>* panes);
489 493
490 // Constructs and initializes the child views. 494 // Constructs and initializes the child views.
491 void InitViews(); 495 void InitViews();
492 496
493 // Callback for the loading animation(s) associated with this view. 497 // Callback for the loading animation(s) associated with this view.
494 void LoadingAnimationCallback(); 498 void LoadingAnimationCallback();
495 499
496 // LoadCompleteListener::Delegate implementation. Creates the JumpList after 500 // LoadCompleteListener::Delegate implementation. Creates and initializes the
497 // the first page load. 501 // |jumplist_| after the first page load.
498 void OnLoadCompleted() override; 502 void OnLoadCompleted() override;
499 503
500 // Returns the BrowserViewLayout. 504 // Returns the BrowserViewLayout.
501 BrowserViewLayout* GetBrowserViewLayout() const; 505 BrowserViewLayout* GetBrowserViewLayout() const;
502 506
503 // Returns the ContentsLayoutManager. 507 // Returns the ContentsLayoutManager.
504 ContentsLayoutManager* GetContentsLayoutManager() const; 508 ContentsLayoutManager* GetContentsLayoutManager() const;
505 509
506 // Prepare to show the Bookmark Bar for the specified WebContents. 510 // Prepare to show the Bookmark Bar for the specified WebContents.
507 // Returns true if the Bookmark Bar can be shown (i.e. it's supported for this 511 // Returns true if the Bookmark Bar can be shown (i.e. it's supported for this
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
676 bool in_process_fullscreen_ = false; 680 bool in_process_fullscreen_ = false;
677 681
678 std::unique_ptr<ExclusiveAccessBubbleViews> exclusive_access_bubble_; 682 std::unique_ptr<ExclusiveAccessBubbleViews> exclusive_access_bubble_;
679 683
680 std::unique_ptr<NewBackShortcutBubble> new_back_shortcut_bubble_; 684 std::unique_ptr<NewBackShortcutBubble> new_back_shortcut_bubble_;
681 base::TimeTicks last_back_shortcut_press_time_; 685 base::TimeTicks last_back_shortcut_press_time_;
682 686
683 #if defined(OS_WIN) 687 #if defined(OS_WIN)
684 // Helper class to listen for completion of first page load. 688 // Helper class to listen for completion of first page load.
685 std::unique_ptr<LoadCompleteListener> load_complete_listener_; 689 std::unique_ptr<LoadCompleteListener> load_complete_listener_;
690
691 // The custom JumpList for Windows 7.
692 scoped_refptr<JumpList> jumplist_;
686 #endif 693 #endif
687 694
688 // The timer used to update frames for the Loading Animation. 695 // The timer used to update frames for the Loading Animation.
689 base::RepeatingTimer loading_animation_timer_; 696 base::RepeatingTimer loading_animation_timer_;
690 697
691 views::UnhandledKeyboardEventHandler unhandled_keyboard_event_handler_; 698 views::UnhandledKeyboardEventHandler unhandled_keyboard_event_handler_;
692 699
693 // If this flag is set then SetFocusToLocationBar() will set focus to the 700 // If this flag is set then SetFocusToLocationBar() will set focus to the
694 // location bar even if the browser window is not active. 701 // location bar even if the browser window is not active.
695 bool force_location_bar_focus_ = false; 702 bool force_location_bar_focus_ = false;
696 703
697 std::unique_ptr<ImmersiveModeController> immersive_mode_controller_; 704 std::unique_ptr<ImmersiveModeController> immersive_mode_controller_;
698 705
699 std::unique_ptr<WebContentsCloseHandler> web_contents_close_handler_; 706 std::unique_ptr<WebContentsCloseHandler> web_contents_close_handler_;
700 707
701 // The class that registers for keyboard shortcuts for extension commands. 708 // The class that registers for keyboard shortcuts for extension commands.
702 std::unique_ptr<ExtensionKeybindingRegistryViews> 709 std::unique_ptr<ExtensionKeybindingRegistryViews>
703 extension_keybinding_registry_; 710 extension_keybinding_registry_;
704 711
705 std::unique_ptr<BrowserWindowHistogramHelper> histogram_helper_; 712 std::unique_ptr<BrowserWindowHistogramHelper> histogram_helper_;
706 713
707 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_{ 714 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_{
708 this}; 715 this};
709 716
710 DISALLOW_COPY_AND_ASSIGN(BrowserView); 717 DISALLOW_COPY_AND_ASSIGN(BrowserView);
711 }; 718 };
712 719
713 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 720 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698