Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2937983002: Remove deps from reloader (Closed)

Created:
3 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -103 lines) Patch
M pkg/front_end/example/incremental_reload/run.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/vm/reload.dart View 1 chunk +0 lines, -96 lines 0 comments Download
M pkg/front_end/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/tool/vm/reload.dart View 1 chunk +95 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
THe code moved from lib/src/vm to tool/vm/, so we can safely use just dev_dependencies for ...
3 years, 6 months ago (2017-06-14 16:23:28 UTC) #1
Paul Berry
lgtm
3 years, 6 months ago (2017-06-14 17:21:00 UTC) #2
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-06-14 17:57:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e5e62f9d8f8512a8ae4c26d42ff7174a9203eaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698