Shift cookie system callbacks to OnceCallback to impedance match mojo.

chrome/browser/browsing_data/browsing_data_cookie_helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_COOKIE_HELPER_H_
 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_COOKIE_HELPER_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 13 matching lines @@
 }
 
 // This class fetches cookie information on behalf of a caller
 // on the UI thread.
 // A client of this class need to call StartFetching from the UI thread to
 // initiate the flow, and it'll be notified by the callback in its UI
 // thread at some later point.
 class BrowsingDataCookieHelper
     : public base::RefCountedThreadSafe<BrowsingDataCookieHelper> {
  public:
   using FetchCallback = base::Callback<void(const net::CookieList&)>;

[Ryan Sleevi, 2017/06/19 07:34:06]

Is there a reason not to change this to a OnceCallback for alignment?

[Randy Smith (Not in Mondays), 2017/06/21 17:54:53]

Yes, though ideal would be to fix it.  The MockBrowsingDataCookieHelper inherits
from this class and uses FetchCallback, and can call the stored callback
multiple times, resulting in test errors.  See
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
(look at the unit tests).

   explicit BrowsingDataCookieHelper(
       net::URLRequestContextGetter* request_context_getter);
 
   // Starts the fetching process, which will notify its completion via
   // callback.
   // This must be called only in the UI thread.
   virtual void StartFetching(const FetchCallback& callback);
 
   // Requests a single cookie to be deleted in the IO thread. This must be
   // called in the UI thread.
@@ skipping 62 matching lines @@
                         const std::string& cookie_line,
                         const net::CookieOptions& options);
 
   // Clears the list of canned cookies.
   void Reset();
 
   // True if no cookie are currently stored.
   bool empty() const;
 
   // BrowsingDataCookieHelper methods.
-  void StartFetching(
-      const net::CookieMonster::GetCookieListCallback& callback) override;
+  void StartFetching(const FetchCallback& callback) override;
   void DeleteCookie(const net::CanonicalCookie& cookie) override;
 
   // Returns the number of stored cookies.
   size_t GetCookieCount() const;
 
   // Returns the map that contains the cookie lists for all frame urls.
   const OriginCookieSetMap& origin_cookie_set_map() {
     return origin_cookie_set_map_;
   }
 
@@ skipping 13 matching lines @@
   void AddCookie(const GURL& frame_url,
                  const net::CanonicalCookie& cookie);
 
   // Map that contains the cookie sets for all frame origins.
   OriginCookieSetMap origin_cookie_set_map_;
 
   DISALLOW_COPY_AND_ASSIGN(CannedBrowsingDataCookieHelper);
 };
 
 #endif  // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_COOKIE_HELPER_H_