runtime/vm/disassembler_arm64.cc - Issue 2937933002: Reduce copying, redundancy & repetition for codegen of comparison instructions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_arm64.cc

Issue 2937933002: Reduce copying, redundancy & repetition for codegen of comparison instructions (Closed)

Patch Set: Feedback from Slava Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/disassembler_arm64.cc

diff --git a/runtime/vm/disassembler_arm64.cc b/runtime/vm/disassembler_arm64.cc

index 448fda328ca7c3203add6a7da79a09de09df01b0..37baf1308ac32eaa5f46a1a7a7b6f43ef3c40429 100644

--- a/runtime/vm/disassembler_arm64.cc

+++ b/runtime/vm/disassembler_arm64.cc

@@ -125,7 +125,7 @@ static const char* extend_names[kMaxExtend] = {

// These condition names are defined in a way to match the native disassembler

// formatting. See for example the command "objdump -d <binary file>".

-static const char* cond_names[kMaxCondition] = {

+static const char* cond_names[kNumberOfConditions] = {

"eq", "ne", "cs", "cc", "mi", "pl", "vs", "vc",

"hi", "ls", "ge", "lt", "gt", "le", "", "invalid",

};

« no previous file with comments | « runtime/vm/disassembler_arm.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »