runtime/vm/constants_x64.h - Issue 2937933002: Reduce copying, redundancy & repetition for codegen of comparison instructions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constants_x64.h

Issue 2937933002: Reduce copying, redundancy & repetition for codegen of comparison instructions (Closed)

Patch Set: Feedback from Slava Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/constants_x64.h

diff --git a/runtime/vm/constants_x64.h b/runtime/vm/constants_x64.h

index 3c24e0bd8859e77f0d09d155a0a50d2c3814c47d..09fd07cc4a835262876a1afc8d81a2fb5c8fdb2e 100644

--- a/runtime/vm/constants_x64.h

+++ b/runtime/vm/constants_x64.h

@@ -147,7 +147,9 @@ enum Condition {

NEGATIVE = SIGN,

POSITIVE = NOT_SIGN,

CARRY = BELOW,

- NOT_CARRY = ABOVE_EQUAL

+ NOT_CARRY = ABOVE_EQUAL,

+ INVALID_CONDITION = 16

};

#define R(reg) (1 << (reg))

« no previous file with comments | « runtime/vm/constants_mips.h ('k') | runtime/vm/disassembler_arm.cc » ('j') | no next file with comments »