runtime/vm/constants_arm.h - Issue 2937933002: Reduce copying, redundancy & repetition for codegen of comparison instructions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constants_arm.h

Issue 2937933002: Reduce copying, redundancy & repetition for codegen of comparison instructions (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/constants_arm.h

diff --git a/runtime/vm/constants_arm.h b/runtime/vm/constants_arm.h

index d1e9bc67fc0bf12b0b1e93462ddb99c0a6952a9c..a716d4949cf1540c6be48f32cd7f060f6934e5e2 100644

--- a/runtime/vm/constants_arm.h

+++ b/runtime/vm/constants_arm.h

@@ -354,7 +354,8 @@ enum Condition {

LE = 13, // signed less than or equal

AL = 14, // always (unconditional)

kSpecialCondition = 15, // special condition (refer to section A3.2.1)

- kMaxCondition = 16,

+ kNumberOfConditions = 16,

+ kInvalidCondition = 16

Vyacheslav Egorov (Google) 2017/06/15 11:32:46 Maybe call it INVALID_CONDITION on all platforms f

erikcorry 2017/06/19 07:15:09 OK, but then I have to rename kNumberOfConditions

};