Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2937843002: Unit-testing AnswerCardResult. (Closed)

Created:
3 years, 6 months ago by vadimt
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unit-testing AnswerCardResult. For this, AnswerCardResult was moved to a separate file. It also now gets AppListControllerDelegate as a param, which allows mocking opening the result URL. Bug=712331 Review-Url: https://codereview.chromium.org/2937843002 Cr-Commit-Position: refs/heads/master@{#479514} Committed: https://chromium.googlesource.com/chromium/src/+/ea690148fbc9c09d88a1d089a881d48402a69a59

Patch Set 1 #

Total comments: 20

Patch Set 2 : CR comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -84 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/search/answer_card_result.h View 1 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/search/answer_card_result.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/search/answer_card_result_unittest.cc View 1 1 chunk +175 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/answer_card_search_provider.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/answer_card_search_provider.cc View 4 chunks +8 lines, -80 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
vadimt
3 years, 6 months ago (2017-06-14 01:26:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937843002/1
3 years, 6 months ago (2017-06-14 01:26:43 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-14 01:26:45 UTC) #6
xiyuan
lgtm https://codereview.chromium.org/2937843002/diff/1/chrome/browser/ui/app_list/search/answer_card_result.h File chrome/browser/ui/app_list/search/answer_card_result.h (right): https://codereview.chromium.org/2937843002/diff/1/chrome/browser/ui/app_list/search/answer_card_result.h#newcode44 chrome/browser/ui/app_list/search/answer_card_result.h:44: }; nit: DISALLOW_COPY_AND_ASSIGN(AnswerCardResult); https://codereview.chromium.org/2937843002/diff/1/chrome/browser/ui/app_list/search/answer_card_result_unittest.cc File chrome/browser/ui/app_list/search/answer_card_result_unittest.cc (right): https://codereview.chromium.org/2937843002/diff/1/chrome/browser/ui/app_list/search/answer_card_result_unittest.cc#newcode25 ...
3 years, 6 months ago (2017-06-14 17:29:26 UTC) #11
vadimt
https://codereview.chromium.org/2937843002/diff/1/chrome/browser/ui/app_list/search/answer_card_result.h File chrome/browser/ui/app_list/search/answer_card_result.h (right): https://codereview.chromium.org/2937843002/diff/1/chrome/browser/ui/app_list/search/answer_card_result.h#newcode44 chrome/browser/ui/app_list/search/answer_card_result.h:44: }; On 2017/06/14 17:29:25, xiyuan wrote: > nit: DISALLOW_COPY_AND_ASSIGN(AnswerCardResult); ...
3 years, 6 months ago (2017-06-14 17:57:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937843002/20001
3 years, 6 months ago (2017-06-14 17:58:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/199960)
3 years, 6 months ago (2017-06-14 19:32:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937843002/20001
3 years, 6 months ago (2017-06-14 19:57:30 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 21:50:14 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea690148fbc9c09d88a1d089a881...

Powered by Google App Engine
This is Rietveld 408576698