[Android] Make WebApplicationInfo and Web Manifest mutually exclusive

chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h"
 
 #include <memory>
 #include <string>
 
 #include "base/callback_forward.h"
@@ skipping 249 matching lines @@
       BuildFetcher(false, &waiter));
   fetcher->OnDidGetWebApplicationInfo(WebApplicationInfo());
   waiter.WaitForDataAvailable();
 
   EXPECT_FALSE(waiter.determined_webapk_compatibility());
   EXPECT_TRUE(waiter.title_available());
 
   fetcher->set_weak_observer(nullptr);
 }
 
+// Test that a page with WebApplicationInfo but no Web Manifest is not WebAPK
+// capable.
+TEST_F(AddToHomescreenDataFetcherTest, WebApplicationInfoNotWebApkCompatible) {
+  const char* kWebApplicationInfoTitle = "Meta Title";
+  WebApplicationInfo web_application_info;
+  web_application_info.title = base::UTF8ToUTF16(kWebApplicationInfoTitle);
+  web_application_info.mobile_capable = WebApplicationInfo::MOBILE_CAPABLE;
+
+  RegisterServiceWorker(GURL(kDefaultStartUrl));
+  SetManifest(GURL(), content::Manifest(), 0);
+
+  ObserverWaiter waiter;
+  scoped_refptr<AddToHomescreenDataFetcher> fetcher(
+      BuildFetcher(true, &waiter));
+  fetcher->OnDidGetWebApplicationInfo(web_application_info);
+  waiter.WaitForDataAvailable();
+
+  EXPECT_TRUE(waiter.determined_webapk_compatibility());
+  EXPECT_FALSE(waiter.is_webapk_compatible());
+
+  EXPECT_TRUE(base::EqualsASCII(fetcher->shortcut_info().name,
+                                kWebApplicationInfoTitle));
+  EXPECT_EQ(blink::kWebDisplayModeStandalone, fetcher->shortcut_info().display);
+
+  fetcher->set_weak_observer(nullptr);
+}
+
 // Class for tests which should be run with AddToHomescreenDataFetcher built
 // with both true and false values of |check_webapk_compatible|.
 class AddToHomescreenDataFetcherTestCommon
     : public AddToHomescreenDataFetcherTest,
       public testing::WithParamInterface<bool> {
  public:
   AddToHomescreenDataFetcherTestCommon() {}
   ~AddToHomescreenDataFetcherTestCommon() override {}
 
   scoped_refptr<AddToHomescreenDataFetcher> BuildFetcher(
@@ skipping 28 matching lines @@
   scoped_refptr<AddToHomescreenDataFetcher> fetcher(BuildFetcher(&waiter));
   fetcher->OnDidGetWebApplicationInfo(web_application_info);
   waiter.WaitForDataAvailable();
 
   EXPECT_TRUE(base::EqualsASCII(fetcher->shortcut_info().name,
                                 kDefaultManifestShortName));
 
   fetcher->set_weak_observer(nullptr);
 }
 
-// Test that when the manifest does not provide either Manifest::short_name nor
-// Manifest::name that:
-// - The page is not WebAPK compatible.
-// - WebApplicationInfo::title is used as the "name".

[dominickn, 2017/06/14 05:16:51]

This behaviour should be preserved.

-TEST_P(AddToHomescreenDataFetcherTestCommon, ManifestNoNameNoShortName) {
-    const char* kWebApplicationInfoTitle = "Meta Title";
-    WebApplicationInfo web_application_info;
-    web_application_info.title = base::UTF8ToUTF16(kWebApplicationInfoTitle);
+// Test that when a manifest is provided that it overwrites the
+// WebapplicationInfo.
+TEST_P(AddToHomescreenDataFetcherTestCommon,
+       ManifestOverwritesWebApplicationInfo) {
+  const char* kWebApplicationInfoTitle = "Meta Title";
+  WebApplicationInfo web_application_info;
+  web_application_info.title = base::UTF8ToUTF16(kWebApplicationInfoTitle);
 
-    content::Manifest manifest(BuildDefaultManifest());
-    manifest.name = base::NullableString16();
-    manifest.short_name = base::NullableString16();
+  content::Manifest manifest(BuildDefaultManifest());
+  manifest.name = base::NullableString16();
+  manifest.short_name = base::NullableString16();
 
-    RegisterServiceWorker(GURL(kDefaultStartUrl));
-    SetManifest(GURL(kDefaultManifestUrl), manifest, 0);
+  RegisterServiceWorker(GURL(kDefaultStartUrl));
+  SetManifest(GURL(kDefaultManifestUrl), manifest, 0);
 
-    ObserverWaiter waiter;
-    scoped_refptr<AddToHomescreenDataFetcher> fetcher(BuildFetcher(&waiter));
-    fetcher->OnDidGetWebApplicationInfo(web_application_info);
-    waiter.WaitForDataAvailable();
+  ObserverWaiter waiter;
+  scoped_refptr<AddToHomescreenDataFetcher> fetcher(BuildFetcher(&waiter));
+  fetcher->OnDidGetWebApplicationInfo(web_application_info);
+  waiter.WaitForDataAvailable();
 
-    EXPECT_FALSE(waiter.is_webapk_compatible());
-    EXPECT_TRUE(base::EqualsASCII(fetcher->shortcut_info().name,
-                                  kWebApplicationInfoTitle));
+  // The name should be empty (even though one is provided in
+  // WebApplicationInfo) because the name was not provided in the Web
+  // Manifest.
+  EXPECT_TRUE(fetcher->shortcut_info().name.empty());
+  EXPECT_EQ(blink::kWebDisplayModeUndefined, fetcher->shortcut_info().display);
 
-    fetcher->set_weak_observer(nullptr);
+  fetcher->set_weak_observer(nullptr);
 }
 
 // Checks that the AddToHomescreenDataFetcher::Observer callbacks are called
 // when a service worker is registered and the manifest fetch times out.
 TEST_P(AddToHomescreenDataFetcherTestCommon, DISABLED_ManifestFetchTimesOut) {
     RegisterServiceWorker(GURL(kDefaultStartUrl));
     SetManifest(GURL(kDefaultManifestUrl), BuildDefaultManifest(), 10000);
 
     ObserverWaiter waiter;
     scoped_refptr<AddToHomescreenDataFetcher> fetcher(BuildFetcher(&waiter));
     fetcher->OnDidGetWebApplicationInfo(WebApplicationInfo());
     waiter.WaitForDataAvailable();
 
     if (check_webapk_compatibility()) {
       EXPECT_TRUE(waiter.determined_webapk_compatibility());
       EXPECT_FALSE(waiter.is_webapk_compatible());
     } else {
       EXPECT_FALSE(waiter.determined_webapk_compatibility());
     }
     // This callback enables the text field in the add-to-homescreen dialog.
     EXPECT_TRUE(waiter.title_available());
 
     fetcher->set_weak_observer(nullptr);
 }
 
 INSTANTIATE_TEST_CASE_P(CheckWebApkCompatibility,
                         AddToHomescreenDataFetcherTestCommon,
                         ::testing::Values(false, true));