[Android] Make WebApplicationInfo and Web Manifest mutually exclusive

chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 189 matching lines @@
 void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
     const InstallableData& data) {
   data_timeout_timer_.Stop();
   badge_icon_.reset();
 
   if (!web_contents() || !weak_observer_ || is_installable_check_complete_)
     return;
 
   is_installable_check_complete_ = true;
 
+  bool use_manifest = false;
   bool webapk_compatible = false;
-  if (check_webapk_compatibility_) {
-    webapk_compatible = (data.error_code == NO_ERROR_DETECTED &&
-                         AreWebManifestUrlsWebApkCompatible(data.manifest));
-    weak_observer_->OnDidDetermineWebApkCompatibility(webapk_compatible);
+  if (!data.manifest.name.string().empty() ||
+      !data.manifest.short_name.string().empty()) {
+    use_manifest = true;
+    base::RecordAction(base::UserMetricsAction("webapps.AddShortcut.Manifest"));
 
-    if (webapk_compatible) {
-      // WebAPKs are wholly defined by the Web Manifest. Ignore the <meta> tag
-      // data received in OnDidGetWebApplicationInfo().
-      shortcut_info_ = ShortcutInfo(GURL());
-    }
-  }
-
-  if (!data.manifest.IsEmpty()) {
-    base::RecordAction(base::UserMetricsAction("webapps.AddShortcut.Manifest"));
+    shortcut_info_ = ShortcutInfo(GURL());
     shortcut_info_.UpdateFromManifest(data.manifest);
     shortcut_info_.manifest_url = data.manifest_url;
 
-    if (webapk_compatible) {
+    if (data.badge_icon && !data.badge_icon->drawsNothing()) {

[dominickn, 2017/06/15 05:16:23]

We only want to grab the badge icon in the case of a WebAPK.

+      shortcut_info_.best_badge_icon_url = data.badge_icon_url;
+      badge_icon_ = *data.badge_icon;
+    }
+
+    // Save the splash screen URL for the later download.
+    shortcut_info_.splash_image_url =
+        ManifestIconSelector::FindBestMatchingIcon(
+            data.manifest.icons, ideal_splash_image_size_in_px_,
+            minimum_splash_image_size_in_px_,
+            content::Manifest::Icon::IconPurpose::ANY);
+    shortcut_info_.ideal_splash_image_size_in_px =
+        ideal_splash_image_size_in_px_;
+    shortcut_info_.minimum_splash_image_size_in_px =
+        minimum_splash_image_size_in_px_;
+
+    webapk_compatible = check_webapk_compatibility_ &&
+                        data.error_code == NO_ERROR_DETECTED &&
+                        AreWebManifestUrlsWebApkCompatible(data.manifest);
+    if (webapk_compatible)
       shortcut_info_.UpdateSource(ShortcutInfo::SOURCE_ADD_TO_HOMESCREEN_PWA);
-
-      if (data.badge_icon && !data.badge_icon->drawsNothing()) {
-        shortcut_info_.best_badge_icon_url = data.badge_icon_url;
-        badge_icon_ = *data.badge_icon;
-      }
-    }
   }
 
-  // Save the splash screen URL for the later download.
-  shortcut_info_.splash_image_url = ManifestIconSelector::FindBestMatchingIcon(
-      data.manifest.icons, ideal_splash_image_size_in_px_,
-      minimum_splash_image_size_in_px_,
-      content::Manifest::Icon::IconPurpose::ANY);
-  shortcut_info_.ideal_splash_image_size_in_px = ideal_splash_image_size_in_px_;
-  shortcut_info_.minimum_splash_image_size_in_px =
-      minimum_splash_image_size_in_px_;
-
+  if (check_webapk_compatibility_)
+    weak_observer_->OnDidDetermineWebApkCompatibility(webapk_compatible);
   weak_observer_->OnUserTitleAvailable(shortcut_info_.user_title);
 
-  if (data.primary_icon) {
+  if (use_manifest && data.primary_icon) {

[dominickn, 2017/06/15 05:16:23]

I don't think we want to guard this behind use_manifest, particularly since
we're trying to use manifest icons more.

     shortcut_info_.best_primary_icon_url = data.primary_icon_url;
 
     CreateLauncherIcon(*(data.primary_icon));
     return;
   }
 
   FetchFavicon();
 }
 
 void AddToHomescreenDataFetcher::FetchFavicon() {
@@ skipping 79 matching lines @@
 void AddToHomescreenDataFetcher::NotifyObserver(const SkBitmap& primary_icon) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   if (!web_contents() || !weak_observer_ || is_icon_saved_)
     return;
 
   is_icon_saved_ = true;
   primary_icon_ = primary_icon;
   is_ready_ = true;
   weak_observer_->OnDataAvailable(shortcut_info_, primary_icon_, badge_icon_);
 }