[CRD iOS] Branching internal and external implementations

remoting/ios/app/app_view_controller.h

Index: remoting/ios/app/app_view_controller.h
diff --git a/remoting/ios/app/app_view_controller.h b/remoting/ios/app/app_view_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..d382aa1c1c43044478e13e9a0c1c5bf2e575fdd3
--- /dev/null
+++ b/remoting/ios/app/app_view_controller.h
@@ -0,0 +1,29 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_IOS_APP_APP_VIEW_CONTROLLER_H_
+#define REMOTING_IOS_APP_APP_VIEW_CONTROLLER_H_
+
+#import <UIKit/UIKit.h>
+
+// The root view controller of the app. It acts as a container controller for
+// |mainViewController|, which will be shown as the primary content of the view.
+// Implementation can add drawer or modal for things like the side menu or help
+// and feedback.
+@interface AppViewController : UIViewController
+
+// For adding new method, please make sure the method is implemented privatel

[nicholss, 2017/06/19 16:32:09]

Fix typos: "methods" or "a new method", "privately"

To ensure there is a mirror of methods you can make a protocol.

setMenuVisible is not a good iOS name. It should be two methods
showMenuAnimated: and hideMenuAnimated:. The set verb is normally only used for
setters. This implies that you are setting the property "menuVisible". 

[Yuwei, 2017/06/19 19:17:26]

Done.

+// on both ios_internal and Chromium before adding the method to the interface
+// and hooking it up to the caller. For deletion, just reverse the procedure.
+// This is to prevent build break in internal buildbot.
+
+- (void)setMenuVisible:(BOOL)visible animated:(BOOL)animated;
+
+- (void)requestSignIn;

[nicholss, 2017/06/19 16:32:10]

I don't think you mean request, this implies that there will be a call to the
sign-in server, I think you mean presentSignIn.

In iOS the naming matters a lot for clarity. In usage the methods are suppose to
read like language. 

[Yuwei, 2017/06/19 19:17:26]

Done.

+
+@property(nonatomic) UIViewController* mainViewController;

[nicholss, 2017/06/19 16:32:10]

mainViewController should be readonly, but I don't understand why you need this.

[Yuwei, 2017/06/19 19:17:26]

This is used to set the main VC to be shown on AppViewController. I moved the
assignment into the init method to simplify it.

+
+@end
+
+#endif  // REMOTING_IOS_APP_APP_VIEW_CONTROLLER_H_