[CRD iOS] Branching internal and external implementations

remoting/ios/app/remoting_view_controller.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 #import "remoting/ios/app/remoting_view_controller.h"
 
 #import "base/mac/bind_objc_block.h"
 #import "ios/third_party/material_components_ios/src/components/AnimationTiming/src/MaterialAnimationTiming.h"
 #import "ios/third_party/material_components_ios/src/components/AppBar/src/MaterialAppBar.h"
 #import "ios/third_party/material_components_ios/src/components/Dialogs/src/MaterialDialogs.h"
 #import "ios/third_party/material_components_ios/src/components/Snackbar/src/MaterialSnackbar.h"
 #import "remoting/ios/app/client_connection_view_controller.h"
 #import "remoting/ios/app/host_collection_view_controller.h"
 #import "remoting/ios/app/host_view_controller.h"
 #import "remoting/ios/app/remoting_menu_view_controller.h"
+#import "remoting/ios/app/remoting_resource_factory.h"
 #import "remoting/ios/app/remoting_theme.h"
 #import "remoting/ios/domain/client_session_details.h"
 #import "remoting/ios/facade/remoting_authentication.h"
 #import "remoting/ios/facade/remoting_service.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "remoting/base/oauth_token_getter.h"
 #include "remoting/client/connect_to_host_info.h"
 
 static CGFloat kHostInset = 5.f;
@@ skipping 39 matching lines @@
     self.navigationItem.title = @"Chrome Remote Desktop";
 
     UIBarButtonItem* menuButton =
         [[UIBarButtonItem alloc] initWithImage:[UIImage imageNamed:@"ic_menu"]
                                          style:UIBarButtonItemStyleDone
                                         target:self
                                         action:@selector(didSelectMenu)];
     self.navigationItem.leftBarButtonItem = menuButton;
 
     UIBarButtonItem* refreshButton = [[UIBarButtonItem alloc]
-        initWithImage:[UIImage imageNamed:@"ic_refresh"]

[nicholss, 2017/06/14 15:37:59]

why are you renaming this asset?

+        initWithImage:[UIImage imageNamed:@"remoting_refresh"]
                 style:UIBarButtonItemStyleDone
                target:self
                action:@selector(didSelectRefresh)];
     self.navigationItem.rightBarButtonItem = refreshButton;
 
     _appBar.headerViewController.headerView.backgroundColor =
         RemotingTheme.hostListBackgroundColor;
     _appBar.navigationBar.backgroundColor =
         RemotingTheme.hostListBackgroundColor;
     MDCNavigationBarTextColorAccessibilityMutator* mutator =
@@ skipping 154 matching lines @@
   [self dismissViewControllerAnimated:true completion:nil];
 }
 
 - (void)didSelectRefresh {
   // TODO(nicholss): Might want to rate limit this. Maybe remoting service
   // controls that.
   [_remotingService requestHostListFetch];
 }
 
 - (void)didSelectMenu {
-  RemotingMenuViewController* menuViewController =
-      [[RemotingMenuViewController alloc] init];
-  [self presentViewController:menuViewController animated:YES completion:nil];
+  [RemotingResourceFactory.defaultFactory presentMenuOnController:self];
 }
 
 - (void)presentStatus {
   MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
   if (_isAuthenticated) {
     message.text = [NSString
         stringWithFormat:@"Currently signed in as %@.",
                          _remotingService.authentication.user.userEmail];
     [MDCSnackbarManager showMessage:message];
   }
 }
 
 @end