chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc - Issue 2937623007: predictors: Move more methods from ResourcePrefetchPredictor into LoadingDataCollector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc

Issue 2937623007: predictors: Move more methods from ResourcePrefetchPredictor into LoadingDataCollector. (Closed)

Patch Set: Undo unneeded added mock class. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/predictors/loading_test_util.cc ('K') | « chrome/browser/predictors/resource_prefetch_predictor.cc ('k') | chrome/browser/predictors/resource_prefetch_predictor_unittest.cc » ('j') | chrome/browser/predictors/resource_prefetch_predictor_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc

diff --git a/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc b/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc

index 015a06d76388ce056c0976bbd945a6ccee6c7c6d..79bc3aed16f945eb6f25330f8370fcfea3e3b708 100644

--- a/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc

+++ b/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc

@@ -50,13 +50,12 @@ void ResourcePrefetchPredictorTabHelper::DidLoadResourceFromMemoryCache(

if (!loading_predictor)

return;

- ResourcePrefetchPredictor::URLRequestSummary summary;

+ URLRequestSummary summary;

summary.navigation_id = NavigationID(web_contents());

summary.resource_url = url;

summary.mime_type = mime_type;

- summary.resource_type =

- ResourcePrefetchPredictor::GetResourceTypeFromMimeType(

- mime_type, resource_type);

+ summary.resource_type = LoadingDataCollector::GetResourceTypeFromMimeType(

+ mime_type, resource_type);

summary.was_cached = true;

auto* collector = loading_predictor->loading_data_collector();

collector->RecordURLResponse(summary);