Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc

Issue 2937623007: predictors: Move more methods from ResourcePrefetchPredictor into LoadingDataCollector. (Closed)
Patch Set: Tests migrated into LoadingDataCollectorTest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc
index cfbd42e162c749c14cf042d036bcdd2e027559da..775f4c91fe4e7f3c9201495997d439caefa85095 100644
--- a/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc
@@ -30,6 +30,13 @@ class MockResourcePrefetchPredictor : public ResourcePrefetchPredictor {
~MockResourcePrefetchPredictor() override {}
};
+class MockLoadingDataCollector : public LoadingDataCollector {
+ public:
+ MOCK_METHOD2(RecordFirstContentfulPaint,
+ void(const predictors::NavigationID& navigation_id,
+ const base::TimeTicks& first_contentful_paint));
+};
+
class LoadingPredictorPageLoadMetricsObserverTest
: public page_load_metrics::PageLoadMetricsObserverTestHarness {
protected:
@@ -41,7 +48,8 @@ class LoadingPredictorPageLoadMetricsObserverTest
base::MakeUnique<testing::StrictMock<MockResourcePrefetchPredictor>>(
config, profile());
page_load_metrics::InitPageLoadTimingForTest(&timing_);
- collector_ = base::MakeUnique<LoadingDataCollector>(predictor_.get());
+ collector_ = base::MakeUnique<testing::StrictMock<LoadingDataCollector>>(
+ predictor_.get(), nullptr, config);
timing_.navigation_start = base::Time::FromDoubleT(1);
timing_.paint_timing->first_paint = base::TimeDelta::FromSeconds(2);
timing_.paint_timing->first_contentful_paint =

Powered by Google App Engine
This is Rietveld 408576698