predictors: Move more methods from ResourcePrefetchPredictor into LoadingDataCollector.

chrome/browser/predictors/loading_stats_collector.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PREDICTORS_LOADING_STATS_COLLECTOR_H_
 #define CHROME_BROWSER_PREDICTORS_LOADING_STATS_COLLECTOR_H_
 
 #include <map>
 #include <memory>
 #include <string>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "chrome/browser/predictors/resource_prefetch_predictor.h"

[alexilin, 2017/06/16 09:31:57]

nit:
We can use just a forward declaration of ResourcePrefetchPredictor now.

[trevordixon, 2017/06/16 10:53:19]

Done.

 #include "chrome/browser/predictors/resource_prefetcher.h"
 #include "url/gurl.h"
 
 namespace predictors {
 
 namespace internal {
 constexpr char kResourcePrefetchPredictorPrecisionHistogram[] =
     "ResourcePrefetchPredictor.LearningPrecision";
 constexpr char kResourcePrefetchPredictorRecallHistogram[] =
     "ResourcePrefetchPredictor.LearningRecall";
@@ skipping 23 matching lines @@
                         const LoadingPredictorConfig& config);
   ~LoadingStatsCollector();
 
   // Records statistics about a finished prefetching operation.
   void RecordPrefetcherStats(
       std::unique_ptr<ResourcePrefetcher::PrefetcherStats> stats);
   // Records a summary of a page load. The summary is collated with speculative
   // actions taken for a given page load if any. The summary is compared with a
   // prediction by ResourcePrefetchPredictor as well.
   // All results are reported to UMA.
-  void RecordPageRequestSummary(
-      const ResourcePrefetchPredictor::PageRequestSummary& summary);
+  void RecordPageRequestSummary(const PageRequestSummary& summary);
   // Evicts all stale stats that are kept in memory. All speculative actions are
   // reported and considered as waste.
   void CleanupAbandonedStats();
 
  private:
   ResourcePrefetchPredictor* predictor_;
   base::TimeDelta max_stats_age_;
   std::map<GURL, std::unique_ptr<ResourcePrefetcher::PrefetcherStats>>
       prefetcher_stats_;
 
   DISALLOW_COPY_AND_ASSIGN(LoadingStatsCollector);
 };
 
 }  // namespace predictors
 
 #endif  // CHROME_BROWSER_PREDICTORS_LOADING_STATS_COLLECTOR_H_