Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4588)

Unified Diff: chrome/browser/chromeos/certificate_provider/certificate_requests.cc

Issue 2937553003: Make CertificateProviderService vend ClientCertIdentities directly. (Closed)
Patch Set: review changes for comments 11 & 12 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/certificate_provider/certificate_requests.cc
diff --git a/chrome/browser/chromeos/certificate_provider/certificate_requests.cc b/chrome/browser/chromeos/certificate_provider/certificate_requests.cc
index ecd2f4633babb105f76b73119f612c484d8c9014..3dc48f0bbbfa12608bf23c2a1a73cc844c9b0379 100644
--- a/chrome/browser/chromeos/certificate_provider/certificate_requests.cc
+++ b/chrome/browser/chromeos/certificate_provider/certificate_requests.cc
@@ -39,7 +39,7 @@ struct CertificateRequests::CertificateRequestState {
std::map<std::string, CertificateInfoList> extension_to_certificates;
// The callback that must be run with the final list of certificates.
- base::Callback<void(const net::CertificateList&)> callback;
+ base::Callback<void(net::ClientCertIdentityList)> callback;
};
CertificateRequests::CertificateRequests() {}
@@ -48,7 +48,7 @@ CertificateRequests::~CertificateRequests() {}
int CertificateRequests::AddRequest(
const std::vector<std::string>& extension_ids,
- const base::Callback<void(const net::CertificateList&)>& callback,
+ const base::Callback<void(net::ClientCertIdentityList)>& callback,
const base::Callback<void(int)>& timeout_callback) {
std::unique_ptr<CertificateRequestState> state(new CertificateRequestState);
state->callback = callback;
@@ -87,7 +87,7 @@ bool CertificateRequests::SetCertificates(
bool CertificateRequests::RemoveRequest(
int request_id,
std::map<std::string, CertificateInfoList>* certificates,
- base::Callback<void(const net::CertificateList&)>* callback) {
+ base::Callback<void(net::ClientCertIdentityList)>* callback) {
const auto it = requests_.find(request_id);
if (it == requests_.end())
return false;

Powered by Google App Engine
This is Rietveld 408576698