chrome/browser/chromeos/certificate_provider/certificate_provider.h - Issue 2937553003: Make CertificateProviderService vend ClientCertIdentities directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/certificate_provider/certificate_provider.h

Issue 2937553003: Make CertificateProviderService vend ClientCertIdentities directly. (Closed)

Patch Set: review changes for comments 11 & 12 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/certificate_manager_model.cc ('k') | chrome/browser/chromeos/certificate_provider/certificate_provider_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/certificate_provider/certificate_provider.h

diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider.h b/chrome/browser/chromeos/certificate_provider/certificate_provider.h

index 09219a331080ad0502f38355df010952ec14855c..8cb3214a44660d3f55d2d823cc08ba3b2f4c6f5c 100644

--- a/chrome/browser/chromeos/certificate_provider/certificate_provider.h

+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider.h

@@ -8,8 +8,7 @@

#include <vector>

#include "base/macros.h"

-#include "base/memory/ref_counted.h"

-#include "net/cert/x509_certificate.h"

+#include "net/ssl/client_cert_identity.h"

namespace chromeos {

@@ -19,7 +18,7 @@ class CertificateProvider {

virtual ~CertificateProvider() {}

virtual void GetCertificates(

- const base::Callback<void(const net::CertificateList&)>& callback) = 0;

+ const base::Callback<void(net::ClientCertIdentityList)>& callback) = 0;

virtual std::unique_ptr<CertificateProvider> Copy() = 0;