Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Unified Diff: chrome/browser/chromeos/login/screens/user_selection_screen.h

Issue 2937553002: Create Mojo Struct for user information used in login/lock screen. (Closed)
Patch Set: comments and rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/user_selection_screen.h
diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen.h b/chrome/browser/chromeos/login/screens/user_selection_screen.h
index f9cc031c5c9e6bed40fd2ee470c25a40a51eba74..dd297773981827c7fa5244a0ddf48bf38a8331ce 100644
--- a/chrome/browser/chromeos/login/screens/user_selection_screen.h
+++ b/chrome/browser/chromeos/login/screens/user_selection_screen.h
@@ -9,6 +9,7 @@
#include <string>
#include <vector>
+#include "ash/public/interfaces/lock_screen.mojom.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/timer/timer.h"
@@ -115,7 +116,18 @@ class UserSelectionScreen
// Determines if user auth status requires online sign in.
static bool ShouldForceOnlineSignIn(const user_manager::User* user);
- std::unique_ptr<base::ListValue> PrepareUserList();
+ // Fills |user_info| with information about |user|.
+ // TODO: Public sesssions exist in login screen, but not lock screen.
+ // We will need public session locales in the future when we change login
+ // screen to view-based as well. See crbug.com/732452.
+ static void FillUserMojoStruct(const user_manager::User* user,
+ bool is_owner,
+ bool is_signin_to_add,
+ AuthType auth_type,
+ ash::mojom::LoginUserInfo* user_info);
+
+ std::unique_ptr<base::ListValue> UpdateAndReturnUserList();
jdufault 2017/06/14 02:20:42 Nit: since you already renamed this what about Upd
xiaoyinh(OOO Sep 11-29) 2017/06/15 18:39:38 Done.
+ std::vector<ash::mojom::LoginUserInfoPtr> UpdateAndReturnUserListForMojo();
protected:
UserBoardView* view_ = nullptr;

Powered by Google App Engine
This is Rietveld 408576698