Introduce x87 port

src/code-stubs-hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "v8.h"
 
 #include "code-stubs.h"
 #include "hydrogen.h"
 #include "lithium.h"
 
@@ skipping 315 matching lines @@
 
 
 template <>
 HValue* CodeStubGraphBuilder<FastCloneShallowArrayStub>::BuildCodeStub() {
   Factory* factory = isolate()->factory();
   HValue* undefined = graph()->GetConstantUndefined();
   AllocationSiteMode alloc_site_mode = casted_stub()->allocation_site_mode();
 
   // This stub is very performance sensitive, the generated code must be tuned
   // so that it doesn't build and eager frame.
+#if !defined(V8_TARGET_ARCH_X87)

[Weiliang, 2014/05/20 05:44:02]

x87 is more easy to spill the double register, so disable it.

[Sven Panne, 2014/05/20 06:21:20]

Please don't introduce any platform-specific #ifdefs into the non-platform
specific parts. I know that we already have a few of them, but we really need to
get rid of them, and don't introduce any more of them. In my POV, this is a
blocker for this CL.

[danno, 2014/05/20 08:18:55]

Yes, this platform-specific define here is a no-go. This is a good example why
we removed the x87 port in the first place, precisely because it is more work to
ensure that there is no frame generated on performance-sensitive stubs, and
since x87 ins't a core platform, it wasn't worth investing the effort. In any
case, you'll need to solve this in a platform independent way, e.g. fixing the
x87 register allocator to avoid having to generate the frame.

[Weiliang, 2014/05/20 08:41:06]

Yes, Thanks a lot for both of you comments. 

To best solve this issue, we would better fix the X87 register allocator to
avoid spilling the double registers. But currently X87 only has rudimentary
X87Stack tracking and in general it cannot handle phi-nodes (comments from
code).I did a very initial try to enhance it, but it seems to take some time.
After considering that this issue only break "x87.debug snapshot=on", I can
remove the code here and hope the CL could land firstly. And then we will
enhance the register allocator to fix this issue. Is it OK?
On 2014/05/20 08:18:55, danno wrote:

[danno, 2014/05/20 12:23:29]

I think it's fine to only support snapshot=off for now for x87, that was the
case for arm64 for a while before the port was complete. Yes, and please remove
the #ifdef here.

   info()->MarkMustNotHaveEagerFrame();
+#endif
 
   HInstruction* allocation_site = Add<HLoadKeyed>(GetParameter(0),
                                                   GetParameter(1),
                                                   static_cast<HValue*>(NULL),
                                                   FAST_ELEMENTS);
   IfBuilder checker(this);
   checker.IfNot<HCompareObjectEqAndBranch, HValue*>(allocation_site,
                                                     undefined);
   checker.Then();
 
@@ skipping 1141 matching lines @@
   return BuildRegExpConstructResult(length, index, input);
 }
 
 
 Handle<Code> RegExpConstructResultStub::GenerateCode() {
   return DoGenerateCode(this);
 }
 
 
 } }  // namespace v8::internal