Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2937213002: Remove ContextClass that is not needed since we're using Vectors (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, ahe, karlklose
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ContextClass that is not needed since we're using Vectors Previously reified representation of contexts, also known as ContextClass, was used in closure conversion. Now that we've switched to Vectors, we no longer need that class. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/c4f4d010fb70c6ef9cbadb0d269ed0bab814e81f

Patch Set 1 #

Patch Set 2 : Merge in latest changes in master (f99509ad42) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -235 lines) Patch
M pkg/kernel/lib/transformations/closure/context.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/converter.dart View 3 chunks +1 line, -3 lines 0 comments Download
D pkg/kernel/lib/transformations/closure/mock.dart View 1 chunk +0 lines, -224 lines 0 comments Download
M pkg/kernel/lib/transformations/closure_conversion.dart View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dmitry Stefantsov
3 years, 6 months ago (2017-06-15 13:24:03 UTC) #2
karlklose
LGTM
3 years, 6 months ago (2017-06-16 07:55:52 UTC) #4
Dmitry Stefantsov
3 years, 6 months ago (2017-06-16 08:32:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c4f4d010fb70c6ef9cbadb0d269ed0bab814e81f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698