Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2937203002: Add J-elements (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add J-elements This adds object for a simple 1-to-1 J-element model to test that the codegen doesn't depend on the frontend model. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/dff4772a0179a8c490cecad91794b517251c59df

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+855 lines, -98 lines) Patch
M pkg/compiler/lib/src/backend_strategy.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 1 6 chunks +619 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 5 chunks +19 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 6 chunks +132 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 2 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/kernel/types.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 5 chunks +12 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_string_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/loop_handler.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +26 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/js_model/model_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
3 years, 6 months ago (2017-06-15 12:29:59 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2937203002/diff/1/pkg/compiler/lib/src/js_model/elements.dart File pkg/compiler/lib/src/js_model/elements.dart (right): https://codereview.chromium.org/2937203002/diff/1/pkg/compiler/lib/src/js_model/elements.dart#newcode240 pkg/compiler/lib/src/js_model/elements.dart:240: /// Library index used for fast lookup in ...
3 years, 6 months ago (2017-06-15 23:10:49 UTC) #3
Johnni Winther
https://codereview.chromium.org/2937203002/diff/1/pkg/compiler/lib/src/js_model/elements.dart File pkg/compiler/lib/src/js_model/elements.dart (right): https://codereview.chromium.org/2937203002/diff/1/pkg/compiler/lib/src/js_model/elements.dart#newcode240 pkg/compiler/lib/src/js_model/elements.dart:240: /// Library index used for fast lookup in [JernelWorldBuilder]. ...
3 years, 6 months ago (2017-06-16 11:06:44 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-06-16 11:52:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
dff4772a0179a8c490cecad91794b517251c59df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698