Flip UseGroupedPermissionInfobars and UsePermissionManagerForMediaRequests

chrome/browser/download/download_request_limiter_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_request_limiter.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "content/public/test/web_contents_tester.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-#if defined(OS_ANDROID)
-#include "chrome/browser/download/download_request_infobar_delegate_android.h"
-#include "chrome/browser/infobars/infobar_service.h"
-#else
 #include "chrome/browser/download/download_permission_request.h"
 #include "chrome/browser/permissions/permission_request_manager.h"
 #include "chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.h"
-#endif
 
 using content::WebContents;
 
 namespace {
 enum TestingAction {
   ACCEPT,
   CANCEL,
   WAIT
 };
 
-#if defined(OS_ANDROID)
 class TestingDelegate {
  public:
   void SetUp(WebContents* web_contents) {
-    InfoBarService::CreateForWebContents(web_contents);
-    fake_create_callback_ =
-        base::Bind(&TestingDelegate::FakeCreate, base::Unretained(this));
-    DownloadRequestInfoBarDelegateAndroid::SetCallbackForTesting(
-        &fake_create_callback_);
-    ResetCounts();

[raymes, 2017/06/20 04:13:46]

I think we should just put if (PermissionRequestManager::IsEnabled()) checks in
each of the functions and merge the two classes. it will be a bit messy but it
won't be code that lives for long. 

-  }
-
-  void TearDown() { UnsetInfobarDelegate(); }
-
-  void LoadCompleted(WebContents* /*web_contents*/) {
-    // No action needed on OS_ANDROID.
-  }
-
-  void ResetCounts() { ask_allow_count_ = 0; }
-
-  int AllowCount() { return ask_allow_count_; }
-
-  void UpdateExpectations(TestingAction action) { testing_action_ = action; }
-
-  void FakeCreate(
-      InfoBarService* infobar_service,
-      base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host) {
-    ask_allow_count_++;
-    switch (testing_action_) {
-      case ACCEPT:
-        host->Accept();
-        break;
-      case CANCEL:
-        host->Cancel();
-        break;
-      case WAIT:
-        break;
-    }
-  }
-
-  void UnsetInfobarDelegate() {
-    DownloadRequestInfoBarDelegateAndroid::SetCallbackForTesting(nullptr);
-  }
-
- private:
-  // Number of times ShouldAllowDownload was invoked.
-  int ask_allow_count_;
-
-  // The action that FakeCreate() should take.
-  TestingAction testing_action_;
-
-  DownloadRequestInfoBarDelegateAndroid::FakeCreateCallback
-      fake_create_callback_;
-};
-#else
-class TestingDelegate {
- public:
-  void SetUp(WebContents* web_contents) {
     PermissionRequestManager::CreateForWebContents(web_contents);
     mock_permission_prompt_factory_.reset(new MockPermissionPromptFactory(
         PermissionRequestManager::FromWebContents(web_contents)));
     PermissionRequestManager::FromWebContents(web_contents)
         ->DisplayPendingRequests();
   }
 
   void TearDown() { mock_permission_prompt_factory_.reset(); }
 
   void LoadCompleted(WebContents* web_contents) {
@@ skipping 18 matching lines @@
       case WAIT:
         response_type = PermissionRequestManager::NONE;
         break;
     }
     mock_permission_prompt_factory_->set_response_type(response_type);
   }
 
  private:
   std::unique_ptr<MockPermissionPromptFactory> mock_permission_prompt_factory_;
 };
-#endif
 }  // namespace
 
 class DownloadRequestLimiterTest : public ChromeRenderViewHostTestHarness {
  public:
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
     testing_delegate_.SetUp(web_contents());
 
     UpdateExpectations(ACCEPT);
     cancel_count_ = continue_count_ = 0;
@@ skipping 413 matching lines @@
   LoadCompleted();
   base::RunLoop().RunUntilIdle();
   ASSERT_EQ(DownloadRequestLimiter::DOWNLOADS_NOT_ALLOWED,
             download_request_limiter_->GetDownloadStatus(web_contents()));
   CanDownload();
   ExpectAndResetCounts(0, 1, 0, __LINE__);
   ASSERT_EQ(DownloadRequestLimiter::DOWNLOADS_NOT_ALLOWED,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 }
 
-#if defined(OS_ANDROID)
 TEST_F(DownloadRequestLimiterTest, DownloadRequestLimiter_RawWebContents) {
   std::unique_ptr<WebContents> web_contents(CreateTestWebContents());
 
   GURL url("http://foo.com/bar");
   web_contents->GetController().LoadURL(
       url, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
 
-  // DownloadRequestLimiter won't try to make a permission bubble if there's
-  // no permission bubble manager, so don't put one on the test WebContents.
-
-  // DownloadRequestLimiter won't try to make an infobar if it doesn't have an
-  // InfoBarService, and we want to test that it will Cancel() instead of
-  // prompting when it doesn't have a InfoBarService, so unset the delegate.
-  testing_delegate_.UnsetInfobarDelegate();
+  // DownloadRequestLimiter won't try to make a permission request if there's
+  // no permission request manager, so don't put one on the test WebContents.
   ExpectAndResetCounts(0, 0, 0, __LINE__);
   EXPECT_EQ(DownloadRequestLimiter::ALLOW_ONE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents.get()));
   // You get one freebie.
   CanDownloadFor(web_contents.get());
   ExpectAndResetCounts(1, 0, 0, __LINE__);
   EXPECT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents.get()));
   OnUserInteractionFor(web_contents.get(), blink::WebInputEvent::kTouchStart);
   EXPECT_EQ(DownloadRequestLimiter::ALLOW_ONE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents.get()));
   CanDownloadFor(web_contents.get());
   ExpectAndResetCounts(1, 0, 0, __LINE__);
   EXPECT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents.get()));
   CanDownloadFor(web_contents.get());
   ExpectAndResetCounts(0, 1, 0, __LINE__);
   EXPECT_EQ(DownloadRequestLimiter::DOWNLOADS_NOT_ALLOWED,
             download_request_limiter_->GetDownloadStatus(web_contents.get()));
   OnUserInteractionFor(web_contents.get(), blink::WebInputEvent::kRawKeyDown);
   EXPECT_EQ(DownloadRequestLimiter::ALLOW_ONE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents.get()));
   CanDownloadFor(web_contents.get());
   ExpectAndResetCounts(1, 0, 0, __LINE__);
   EXPECT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents.get()));
 }
-#endif
 
 TEST_F(DownloadRequestLimiterTest,
        DownloadRequestLimiter_SetHostContentSetting) {
   NavigateAndCommit(GURL("http://foo.com/bar"));
   LoadCompleted();
   SetHostContentSetting(web_contents(), CONTENT_SETTING_ALLOW);
 
   CanDownload();
   ExpectAndResetCounts(1, 0, 0, __LINE__);
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
@@ skipping 65 matching lines @@
   // changing the content setting).
   UpdateContentSettings(web_contents(), CONTENT_SETTING_ASK);
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
   UpdateExpectations(WAIT);
   CanDownload();
   ExpectAndResetCounts(0, 0, 1, __LINE__);
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 }