Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2937143002: Edit docs as per Siggi's feedback. (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +8 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Emily Fortuna
3 years, 6 months ago (2017-06-15 00:11:15 UTC) #2
Siggi Cherem (dart-lang)
lgtm, thanks! https://codereview.chromium.org/2937143002/diff/1/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2937143002/diff/1/pkg/compiler/lib/src/closure.dart#newcode122 pkg/compiler/lib/src/closure.dart:122: /// if y is modified elsewhere within ...
3 years, 6 months ago (2017-06-15 00:12:24 UTC) #3
Emily Fortuna
https://codereview.chromium.org/2937143002/diff/1/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2937143002/diff/1/pkg/compiler/lib/src/closure.dart#newcode122 pkg/compiler/lib/src/closure.dart:122: /// if y is modified elsewhere within its scope, ...
3 years, 6 months ago (2017-06-15 00:13:35 UTC) #4
Emily Fortuna
3 years, 6 months ago (2017-06-15 00:14:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e599fd2139939efeb7f079694ac44ce8062595f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698