[OriginChip] Re-enable the chip when reverting the text in the omnibox.

[OriginChip] Re-enable the chip when reverting the text in the omnibox.  This ensures that when we revert the text after a navigation or reload, the URL not only disappears but also the origin chip reappears.

BUG=371684
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271485

[Peter Kasting, 2014-05-19 16:49:35]

This doesn't seem like it would be right?  I'd think this would make clicking
the chip, editing the URL, then hitting escape cause the chip to re-appear,
which isn't what we want.

Maybe you can say more about which piece of the bug report this is trying to
fix.

[Justin Donnelly, 2014-05-19 17:04:47]

On 2014/05/19 16:49:35, Peter Kasting wrote:
> This doesn't seem like it would be right?  I'd think this would make clicking
> the chip, editing the URL, then hitting escape cause the chip to re-appear,
> which isn't what we want.
> 
> Maybe you can say more about which piece of the bug report this is trying to
> fix.

Hitting esc calls RevertWithoutResettingSearchTermReplacement, so neither
set_origin_chip_enabled nor set_url_replacment is called in that case.  This
change covers the case where you edit the text but then click forward, back or
reload.  Updated the description to describe the motivation.

[Peter Kasting, 2014-05-19 17:06:02]

LGTM

Again, I feel like these sorts of things really could benefit from some
unittests...

[Justin Donnelly, 2014-05-19 17:13:03]

On Mon, May 19, 2014 at 10:06 AM, <pkasting@chromium.org> wrote:

> Again, I feel like these sorts of things really could benefit from some
> unittests...
>

I totally agree and I totally feel like an @&*#$ for repeatedly saying that
I intend to add unit tests.  But... I'm going to add some unit tests soon.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Justin Donnelly, 2014-05-19 17:14:21]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2014-05-19 17:16:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/293713002/1

[commit-bot: I haz the power, 2014-05-19 18:06:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-19 19:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 19:25:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Justin Donnelly, 2014-05-19 21:05:12]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2014-05-19 21:06:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/293713002/1

[commit-bot: I haz the power, 2014-05-19 21:20:16]

Change committed as 271485