ios/chrome/browser/passwords/password_generation_agent.mm - Issue 2937033002: [Password Generation] Send a boolean flag of whether user changed generated password

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/password_generation_agent.mm

Issue 2937033002: [Password Generation] Send a boolean flag of whether user changed generated password (Closed)

Patch Set: Changes addressed to vabr@ comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/passwords/password_generation_agent.mm

diff --git a/ios/chrome/browser/passwords/password_generation_agent.mm b/ios/chrome/browser/passwords/password_generation_agent.mm

index 67671677d07eeb5e1f7dfb59827b3b2c9ee849c7..57790216d7390273754960ad670f189fabe8cf8c 100644

--- a/ios/chrome/browser/passwords/password_generation_agent.mm

+++ b/ios/chrome/browser/passwords/password_generation_agent.mm

@@ -356,9 +356,8 @@ passwordManagerDriver:(password_manager::PasswordManagerDriver*)driver

return;

if (strongSelf->_passwordManager) {

// Might be null in tests.

- strongSelf->_passwordManager->SetHasGeneratedPasswordForForm(

- strongSelf->_passwordManagerDriver,

- *strongSelf->_possibleAccountCreationForm, true);

+ strongSelf->_passwordManager->OnPresaveGeneratedPassword(

+ *strongSelf->_possibleAccountCreationForm);

}

if (strongSelf->_accessoryViewReadyCompletion) {

strongSelf->_accessoryViewReadyCompletion(

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | no next file » | no next file with comments »