Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 2937033002: [Password Generation] Send a boolean flag of whether user changed generated password (Closed)
Patch Set: Changes addressed to vabr@ comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
index bf704cd7b37796574d53a338cef3f75b34b0d3ef..0e1ec6aef92cd909ff66bbb3a7d52f681314b63a 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
@@ -62,9 +62,9 @@ PasswordGenerationPopupControllerImpl::GetOrCreate(
previous->Hide();
PasswordGenerationPopupControllerImpl* controller =
- new PasswordGenerationPopupControllerImpl(
- bounds, form, max_length, password_manager, driver, observer,
- web_contents, container_view);
+ new PasswordGenerationPopupControllerImpl(bounds, form, max_length,
+ driver, observer, web_contents,
+ container_view);
return controller->GetWeakPtr();
}
@@ -72,14 +72,12 @@ PasswordGenerationPopupControllerImpl::PasswordGenerationPopupControllerImpl(
const gfx::RectF& bounds,
const PasswordForm& form,
int max_length,
- password_manager::PasswordManager* password_manager,
password_manager::PasswordManagerDriver* driver,
PasswordGenerationPopupObserver* observer,
content::WebContents* web_contents,
gfx::NativeView container_view)
: view_(NULL),
form_(form),
- password_manager_(password_manager),
driver_(driver),
observer_(observer),
generator_(new PasswordGenerator(max_length)),
@@ -148,7 +146,6 @@ void PasswordGenerationPopupControllerImpl::PasswordAccepted() {
return;
driver_->GeneratedPasswordAccepted(current_password_);
- password_manager_->SetHasGeneratedPasswordForForm(driver_, form_, true);
Hide();
}

Powered by Google App Engine
This is Rietveld 408576698