Issue 293693002: Try out SkMatrix::Concat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293693002: Try out SkMatrix::Concat. (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Try out SkMatrix::Concat. This should RVO to the same as doing it on the stack with setConcat. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14782

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -7 lines)			Patch
M	include/core/SkMatrix.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/record/SkRecordDraw.cpp	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	tests/MatrixTest.cpp	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

reed1

is it useful for the impl to be seen in the header? just curious. lgtm

6 years, 7 months ago (2014-05-19 15:30:34 UTC) #2

mtklein

On 2014/05/19 15:30:34, reed1 wrote: > is it useful for the impl to be seen ...

6 years, 7 months ago (2014-05-19 15:44:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/293693002/20001

6 years, 7 months ago (2014-05-19 15:44:59 UTC) #6

Message was sent while issue was closed.

Change committed as 14782