Add not_needed function

tools/gn/functions_target_unittest.cc

Index: tools/gn/functions_target_unittest.cc
diff --git a/tools/gn/functions_target_unittest.cc b/tools/gn/functions_target_unittest.cc
index 525bc7cbdb809e2eef2872e3935da64c4d219f88..4c721b3ce6fd29fc325f940de4163770a8fe7f68 100644
--- a/tools/gn/functions_target_unittest.cc
+++ b/tools/gn/functions_target_unittest.cc
@@ -37,6 +37,32 @@ TEST(FunctionsTarget, CheckUnused) {
   ASSERT_TRUE(err.has_error());
 }
 
+// Checks that we find uses of identifiers marked as not needed.
+TEST(FunctionsTarget, CheckNotNeeded) {
+  Scheduler scheduler;
+  TestWithScope setup;
+
+  // The target generator needs a place to put the targets or it will fail.
+  Scope::ItemVector item_collector;
+  setup.scope()->set_item_collector(&item_collector);
+
+  TestParseInput nonscoped_input(
+      "a = 1\n"
+      "not_needed([ \"a\" ])\n");
+  ASSERT_FALSE(nonscoped_input.has_error());
+  Err err;
+  nonscoped_input.parsed()->Execute(setup.scope(), &err);
+  ASSERT_FALSE(err.has_error()) << err.message();
+
+  TestParseInput scoped_input(
+      "a = {x = 1 y = 2}\n"
+      "not_needed(a, \"*\")\n");

[brettw, 2017/06/28 20:16:49]

Can you test the exclusion list also?

[Petr Hosek, 2017/06/28 23:21:32]

Done.

+  ASSERT_FALSE(scoped_input.has_error());
+  err = Err();
+  scoped_input.parsed()->Execute(setup.scope(), &err);
+  ASSERT_FALSE(err.has_error()) << err.message();
+}
+
 // Checks that the defaults applied to a template invoked by target() use
 // the name of the template, rather than the string "target" (which is the
 // name of the actual function being called).