tools/gn/function_forward_variables_from.cc - Issue 2936923002: Add not_needed function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_forward_variables_from.cc

Issue 2936923002: Add not_needed function (Closed)

Patch Set: Rename to not_needed Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/function_forward_variables_from.cc

diff --git a/tools/gn/function_forward_variables_from.cc b/tools/gn/function_forward_variables_from.cc

index 7c92ec3a21f06eaea33ea030c2cd8df42a7e45a4..9c1fdaccad30afb42b043c182650dfb92e7e9d35 100644

--- a/tools/gn/function_forward_variables_from.cc

+++ b/tools/gn/function_forward_variables_from.cc

@@ -27,7 +27,7 @@ void ForwardAllValues(const FunctionCallNode* function,

options.excluded_values = exclusion_set;

source->NonRecursiveMergeTo(dest, options, function,

"source scope", err);

- source->MarkAllUsed();

+ source->MarkAllUsed(err);

}

void ForwardValuesFromList(Scope* source,