Issue 2936833003: Fix for mismatch between existing FileState data and UnlinkedUnit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2936833003: Fix for mismatch between existing FileState data and UnlinkedUnit. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for mismatch between existing FileState data and UnlinkedUnit. I started implementing using of UnlinkedUnit, and found that I like isShow and names better. Also, parts are always only URIs. And I think that we are not going to need setters. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ba189d1fd32e08a74ea805daa0ba9383172d90b8

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -151 lines)			Patch
	M	pkg/front_end/lib/src/incremental/format.dart	View		10 chunks	+63 lines, -83 lines	0 comments	Download
	M	pkg/front_end/test/src/incremental/format_test.dart	View		3 chunks	+38 lines, -68 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 6 months ago (2017-06-13 20:33:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ba189d1fd32e08a74ea805daa0ba9383172d90b8 (presubmit successful).