Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/telemetry/telemetry/page/actions/pinch.js

Issue 293683002: Synthetic pinch gesture take scale factor as parameter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/tough_pinch_zoom_cases.py ('k') | tools/telemetry/telemetry/page/actions/pinch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/actions/pinch.js
diff --git a/tools/telemetry/telemetry/page/actions/pinch.js b/tools/telemetry/telemetry/page/actions/pinch.js
index 0a2b15d0af7eaa28962d7f80dacaf9971f838dab..6e3e6017088005139ca9fe171e92997930c592b5 100644
--- a/tools/telemetry/telemetry/page/actions/pinch.js
+++ b/tools/telemetry/telemetry/page/actions/pinch.js
@@ -15,15 +15,13 @@
this.element_ = opt_options.element;
this.left_anchor_percentage_ = opt_options.left_anchor_percentage;
this.top_anchor_percentage_ = opt_options.top_anchor_percentage;
- this.zoom_in_ = opt_options.zoom_in;
- this.pixels_to_cover_ = opt_options.pixels_to_cover;
+ this.scale_factor_ = opt_options.scale_factor;
this.speed_ = opt_options.speed;
} else {
this.element_ = document.body;
this.left_anchor_percentage_ = 0.5;
this.top_anchor_percentage_ = 0.5;
- this.zoom_in_ = true;
- this.pixels_to_cover_ = 4000;
+ this.scale_factor_ = 2.0;
this.speed_ = 800;
}
}
@@ -59,8 +57,7 @@
rect.left + rect.width * this.options_.left_anchor_percentage_;
var anchor_top =
rect.top + rect.height * this.options_.top_anchor_percentage_;
- chrome.gpuBenchmarking.pinchBy(this.options_.zoom_in_,
- this.options_.pixels_to_cover_,
+ chrome.gpuBenchmarking.pinchBy(this.options_.scale_factor_,
anchor_left, anchor_top,
this.onGestureComplete_.bind(this),
this.options_.speed_);
« no previous file with comments | « tools/perf/page_sets/tough_pinch_zoom_cases.py ('k') | tools/telemetry/telemetry/page/actions/pinch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698