Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: test/cctest/interpreter/bytecode_expectations/StandardForLoop.golden

Issue 2936813002: Move closing of generators upon final return to the generator-resume builtin. (Closed)
Patch Set: Add TODO Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/Modules.golden ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/StandardForLoop.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/StandardForLoop.golden b/test/cctest/interpreter/bytecode_expectations/StandardForLoop.golden
index d71f1a893d100993df2926012ca5bcf6751753d5..4c57dfa31f2f1741151c6212a22fd0f4d50a088e 100644
--- a/test/cctest/interpreter/bytecode_expectations/StandardForLoop.golden
+++ b/test/cctest/interpreter/bytecode_expectations/StandardForLoop.golden
@@ -273,7 +273,7 @@ snippet: "
"
frame size: 11
parameter count: 1
-bytecode array length: 184
+bytecode array length: 172
bytecodes: [
B(Mov), R(new_target), R(7),
B(Ldar), R(new_target),
@@ -308,7 +308,6 @@ bytecodes: [
B(SwitchOnSmiNoFeedback), U8(1), U8(2), I8(0),
B(Ldar), R(9),
/* 11 E> */ B(Throw),
- B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(7), U8(1),
B(Ldar), R(9),
/* 62 S> */ B(Return),
/* 31 S> */ B(LdaZero),
@@ -350,14 +349,11 @@ bytecodes: [
B(Jump), U8(5),
B(JumpLoop), U8(68), I8(0),
B(LdaUndefined),
- B(Star), R(9),
- B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(7), U8(1),
- B(Ldar), R(9),
/* 62 S> */ B(Return),
]
constant pool: [
Smi [45],
- Smi [14],
+ Smi [10],
Smi [7],
]
handlers: [
@@ -372,7 +368,7 @@ snippet: "
"
frame size: 11
parameter count: 1
-bytecode array length: 276
+bytecode array length: 260
bytecodes: [
B(Mov), R(new_target), R(6),
B(Ldar), R(new_target),
@@ -407,7 +403,6 @@ bytecodes: [
B(SwitchOnSmiNoFeedback), U8(2), U8(2), I8(0),
B(Ldar), R(8),
/* 11 E> */ B(Throw),
- B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(6), U8(1),
B(Ldar), R(8),
/* 56 S> */ B(Return),
/* 31 S> */ B(LdaZero),
@@ -440,7 +435,7 @@ bytecodes: [
/* 36 E> */ B(TestLessThan), R(0), U8(5),
B(JumpIfFalse), U8(4),
B(Jump), U8(4),
- B(Jump), U8(107),
+ B(Jump), U8(103),
B(Ldar), R(7),
B(SwitchOnSmiNoFeedback), U8(5), U8(1), I8(1),
B(LdaSmi), I8(-2),
@@ -451,7 +446,7 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kAbort), R(8), U8(1),
B(LdaSmi), I8(1),
B(TestEqual), R(5), U8(6),
- B(JumpIfFalse), U8(67),
+ B(JumpIfFalse), U8(63),
/* 18 E> */ B(StackCheck),
/* 47 S> */ B(LdaSmi), I8(1),
B(Mov), R(0), R(8),
@@ -470,33 +465,29 @@ bytecodes: [
B(SwitchOnSmiNoFeedback), U8(6), U8(2), I8(0),
B(Ldar), R(8),
/* 47 E> */ B(Throw),
- B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(6), U8(1),
B(Ldar), R(8),
/* 56 S> */ B(Return),
B(LdaZero),
B(Star), R(5),
B(Mov), R(0), R(3),
B(Ldar), R(3),
- B(JumpLoop), U8(90), I8(1),
+ B(JumpLoop), U8(86), I8(1),
B(LdaSmi), I8(1),
/* 54 E> */ B(TestEqual), R(5), U8(7),
B(JumpIfFalse), U8(4),
B(Jump), U8(5),
- B(JumpLoop), U8(160), I8(0),
+ B(JumpLoop), U8(156), I8(0),
B(LdaUndefined),
- B(Star), R(8),
- B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(6), U8(1),
- B(Ldar), R(8),
/* 56 S> */ B(Return),
]
constant pool: [
Smi [45],
- Smi [86],
- Smi [14],
+ Smi [82],
+ Smi [10],
Smi [7],
Smi [56],
Smi [48],
- Smi [14],
+ Smi [10],
Smi [7],
]
handlers: [
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/Modules.golden ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698