Move closing of generators upon final return to the generator-resume builtin.

test/cctest/interpreter/bytecode_expectations/Generators.golden

 #
 # Autogenerated by generate-bytecode-expectations.
 #
 
 ---
 wrap: no
 test function name: f
 
 ---
 snippet: "
   function* f() { }
   f();
 "
 frame size: 5
 parameter count: 1
-bytecode array length: 104
+bytecode array length: 92
 bytecodes: [
                 B(Mov), R(new_target), R(1),
                 B(Ldar), R(new_target),
                 B(JumpIfUndefined), U8(25),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetContext), R(1), U8(1),
                 B(PushContext), R(3),
                 B(RestoreGeneratorState), R(1),
                 B(Star), R(2),
                 B(SwitchOnSmiNoFeedback), U8(0), U8(1), I8(0),
                 B(LdaSmi), I8(79),
@@ skipping 14 matching lines @@
   /*   16 S> */ B(Return),
                 B(RestoreGeneratorRegisters), R(1), R(0), U8(3),
                 B(LdaSmi), I8(-2),
                 B(Star), R(2),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetInputOrDebugPos), R(1), U8(1),
                 B(Star), R(3),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(1), U8(1),
                 B(SwitchOnSmiNoFeedback), U8(1), U8(2), I8(0),
                 B(Ldar), R(3),
   /*   11 E> */ B(Throw),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(1), U8(1),
                 B(Ldar), R(3),
   /*   16 S> */ B(Return),
                 B(LdaUndefined),
-                B(Star), R(3),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(1), U8(1),
-                B(Ldar), R(3),
   /*   16 S> */ B(Return),
 ]
 constant pool: [
   Smi [45],
-  Smi [14],
+  Smi [10],
   Smi [7],
 ]
 handlers: [
 ]
 
 ---
 snippet: "
   function* f() { yield 42 }
   f();
 "
 frame size: 6
 parameter count: 1
-bytecode array length: 158
+bytecode array length: 142
 bytecodes: [
                 B(Mov), R(new_target), R(1),
                 B(Ldar), R(new_target),
                 B(JumpIfUndefined), U8(25),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetContext), R(1), U8(1),
                 B(PushContext), R(3),
                 B(RestoreGeneratorState), R(1),
                 B(Star), R(2),
                 B(SwitchOnSmiNoFeedback), U8(0), U8(2), I8(0),
                 B(LdaSmi), I8(79),
@@ skipping 14 matching lines @@
   /*   25 S> */ B(Return),
                 B(RestoreGeneratorRegisters), R(1), R(0), U8(3),
                 B(LdaSmi), I8(-2),
                 B(Star), R(2),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetInputOrDebugPos), R(1), U8(1),
                 B(Star), R(3),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(1), U8(1),
                 B(SwitchOnSmiNoFeedback), U8(2), U8(2), I8(0),
                 B(Ldar), R(3),
   /*   11 E> */ B(Throw),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(1), U8(1),
                 B(Ldar), R(3),
   /*   25 S> */ B(Return),
   /*   16 S> */ B(LdaSmi), I8(42),
                 B(Star), R(3),
                 B(LdaSmi), I8(1),
                 B(SuspendGenerator), R(1), R(0), U8(3), U8(0),
                 B(LdaFalse),
                 B(Star), R(5),
                 B(Mov), R(3), R(4),
                 B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(4), U8(2),
   /*   25 S> */ B(Return),
                 B(RestoreGeneratorRegisters), R(1), R(0), U8(3),
                 B(LdaSmi), I8(-2),
                 B(Star), R(2),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetInputOrDebugPos), R(1), U8(1),
                 B(Star), R(3),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(1), U8(1),
                 B(SwitchOnSmiNoFeedback), U8(4), U8(2), I8(0),
                 B(Ldar), R(3),
   /*   16 E> */ B(Throw),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(1), U8(1),
                 B(Ldar), R(3),
   /*   25 S> */ B(Return),
                 B(LdaUndefined),
-                B(Star), R(3),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(1), U8(1),
-                B(Ldar), R(3),
   /*   25 S> */ B(Return),
 ]
 constant pool: [
   Smi [45],
-  Smi [99],
-  Smi [14],
+  Smi [95],
+  Smi [10],
   Smi [7],
-  Smi [14],
+  Smi [10],
   Smi [7],
 ]
 handlers: [
 ]
 
 ---
 snippet: "
   function* f() { for (let x of [42]) yield x }
   f();
 "
 frame size: 19
 parameter count: 1
-bytecode array length: 447
+bytecode array length: 431
 bytecodes: [
                 B(Mov), R(new_target), R(10),
                 B(Ldar), R(new_target),
                 B(JumpIfUndefined), U8(25),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetContext), R(10), U8(1),
                 B(PushContext), R(12),
                 B(RestoreGeneratorState), R(10),
                 B(Star), R(11),
                 B(SwitchOnSmiNoFeedback), U8(0), U8(2), I8(0),
                 B(LdaSmi), I8(79),
@@ skipping 14 matching lines @@
   /*   44 S> */ B(Return),
                 B(RestoreGeneratorRegisters), R(10), R(0), U8(12),
                 B(LdaSmi), I8(-2),
                 B(Star), R(11),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetInputOrDebugPos), R(10), U8(1),
                 B(Star), R(12),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(10), U8(1),
                 B(SwitchOnSmiNoFeedback), U8(2), U8(2), I8(0),
                 B(Ldar), R(12),
   /*   11 E> */ B(Throw),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(10), U8(1),
                 B(Ldar), R(12),
   /*   44 S> */ B(Return),
                 B(LdaZero),
                 B(Star), R(6),
                 B(Mov), R(context), R(14),
                 B(Mov), R(context), R(15),
   /*   30 S> */ B(CreateArrayLiteral), U8(4), U8(3), U8(17),
                 B(Star), R(16),
                 B(LdaNamedProperty), R(16), U8(5), U8(4),
                 B(Star), R(17),
@@ skipping 115 matching lines @@
                 B(InvokeIntrinsic), U8(Runtime::k_Call), R(15), U8(2),
                 B(Star), R(9),
                 B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(9), U8(1),
                 B(JumpIfToBooleanFalse), U8(4),
                 B(Jump), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(9), U8(1),
                 B(Ldar), R(14),
                 B(SetPendingMessage),
                 B(Ldar), R(12),
                 B(SwitchOnSmiNoFeedback), U8(17), U8(2), I8(0),
-                B(Jump), U8(12),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(10), U8(1),
+                B(Jump), U8(8),
                 B(Ldar), R(13),
   /*   44 S> */ B(Return),
                 B(Ldar), R(13),
                 B(ReThrow),
                 B(LdaUndefined),
-                B(Star), R(12),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(10), U8(1),
-                B(Ldar), R(12),
   /*   44 S> */ B(Return),
 ]
 constant pool: [
   Smi [45],
-  Smi [111],
-  Smi [14],
+  Smi [107],
+  Smi [10],
   Smi [7],
   TUPLE2_TYPE,
   SYMBOL_TYPE,
   Smi [87],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
   Smi [15],
   Smi [7],
   ONE_BYTE_INTERNALIZED_STRING_TYPE [".catch"],
   FIXED_ARRAY_TYPE,
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
   ONE_BYTE_INTERNALIZED_STRING_TYPE [""],
   FIXED_ARRAY_TYPE,
   Smi [6],
-  Smi [13],
+  Smi [9],
 ]
 handlers: [
-  [100, 292, 298],
-  [103, 256, 258],
-  [359, 369, 371],
+  [96, 288, 294],
+  [99, 252, 254],
+  [355, 365, 367],
 ]
 
 ---
 snippet: "
   function* g() { yield 42 }
   function* f() { yield* g() }
   f();
 "
 frame size: 15
 parameter count: 1
-bytecode array length: 500
+bytecode array length: 476
 bytecodes: [
                 B(Mov), R(new_target), R(9),
                 B(Ldar), R(new_target),
                 B(JumpIfUndefined), U8(25),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetContext), R(9), U8(1),
                 B(PushContext), R(11),
                 B(RestoreGeneratorState), R(9),
                 B(Star), R(10),
                 B(SwitchOnSmiNoFeedback), U8(0), U8(2), I8(0),
                 B(LdaSmi), I8(79),
@@ skipping 14 matching lines @@
   /*   54 S> */ B(Return),
                 B(RestoreGeneratorRegisters), R(9), R(0), U8(11),
                 B(LdaSmi), I8(-2),
                 B(Star), R(10),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetInputOrDebugPos), R(9), U8(1),
                 B(Star), R(11),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(9), U8(1),
                 B(SwitchOnSmiNoFeedback), U8(2), U8(2), I8(0),
                 B(Ldar), R(11),
   /*   38 E> */ B(Throw),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(9), U8(1),
                 B(Ldar), R(11),
   /*   54 S> */ B(Return),
   /*   43 S> */ B(LdaUndefined),
                 B(Star), R(1),
                 B(LdaZero),
                 B(Star), R(2),
                 B(LdaUndefined),
                 B(Star), R(3),
                 B(LdaGlobal), U8(4), U8(5),
                 B(Star), R(13),
@@ skipping 16 matching lines @@
                 B(StackCheck),
                 B(LdaZero),
                 B(TestEqualStrict), R(2), U8(15),
                 B(Mov), R(2), R(11),
                 B(JumpIfTrue), U8(18),
                 B(LdaSmi), I8(1),
                 B(TestEqualStrict), R(11), U8(19),
                 B(JumpIfTrue), U8(39),
                 B(LdaSmi), I8(2),
                 B(TestEqualStrict), R(11), U8(28),
-                B(JumpIfTrue), U8(78),
-                B(Jump), U8(236),
+                B(JumpIfTrue), U8(74),
+                B(Jump), U8(232),
                 B(LdaNamedProperty), R(4), U8(7), U8(13),
                 B(Star), R(12),
                 B(CallProperty1), R(12), R(4), R(1), U8(11),
                 B(Star), R(3),
                 B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(3), U8(1),
                 B(JumpIfToBooleanFalse), U8(4),
                 B(Jump), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(3), U8(1),
-                B(Jump), U8(208),
+                B(Jump), U8(204),
                 B(LdaNamedProperty), R(4), U8(8), U8(16),
                 B(Star), R(3),
                 B(TestUndetectable),
-                B(JumpIfFalse), U8(9),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(9), U8(1),
+                B(JumpIfFalse), U8(5),
                 B(Ldar), R(1),
   /*   54 S> */ B(Return),
                 B(Mov), R(3), R(12),
                 B(Mov), R(4), R(13),
                 B(Mov), R(1), R(14),
                 B(InvokeIntrinsic), U8(Runtime::k_Call), R(12), U8(3),
                 B(Star), R(3),
                 B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(3), U8(1),
                 B(JumpIfToBooleanFalse), U8(4),
                 B(Jump), U8(7),
@@ skipping 71 matching lines @@
                 B(Ldar), R(11),
   /*   54 S> */ B(Return),
                 B(RestoreGeneratorRegisters), R(9), R(0), U8(11),
                 B(LdaSmi), I8(-2),
                 B(Star), R(10),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetInputOrDebugPos), R(9), U8(1),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetInputOrDebugPos), R(0), U8(1),
                 B(Star), R(1),
                 B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
                 B(Star), R(2),
-                B(Wide), B(JumpLoop), U16(327), I16(0),
+                B(Wide), B(JumpLoop), U16(323), I16(0),
                 B(LdaSmi), I8(1),
                 B(TestEqualStrict), R(2), U8(31),
-                B(JumpIfFalse), U8(15),
+                B(JumpIfFalse), U8(7),
                 B(LdaNamedProperty), R(3), U8(14), U8(32),
-                B(Star), R(11),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(9), U8(1),
-                B(Ldar), R(11),
   /*   54 S> */ B(Return),
                 B(LdaNamedProperty), R(3), U8(14), U8(34),
                 B(Star), R(8),
                 B(LdaUndefined),
-                B(Star), R(11),
-                B(InvokeIntrinsic), U8(Runtime::k_GeneratorClose), R(9), U8(1),
-                B(Ldar), R(11),
   /*   54 S> */ B(Return),
 ]
 constant pool: [
   Smi [45],
-  Smi [115],
-  Smi [14],
+  Smi [111],
+  Smi [10],
   Smi [7],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["g"],
   SYMBOL_TYPE,
-  Smi [300],
+  Smi [296],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["throw"],
   ONE_BYTE_INTERNALIZED_STRING_TYPE [""],
   ONE_BYTE_INTERNALIZED_STRING_TYPE [".catch"],
   FIXED_ARRAY_TYPE,
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
 ]
 handlers: [
-  [310, 320, 322],
+  [302, 312, 314],
 ]