Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: components/metrics/metrics_service_accessor.cc

Issue 2936733002: Instrumentation to debug actions memory leak.
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service_accessor.cc
diff --git a/components/metrics/metrics_service_accessor.cc b/components/metrics/metrics_service_accessor.cc
index 29b67bd911888a5eedd2d244fbe70aac27899987..19c1fb9ba4148671c5ea9d82ebcf4ae47b3a814e 100644
--- a/components/metrics/metrics_service_accessor.cc
+++ b/components/metrics/metrics_service_accessor.cc
@@ -6,6 +6,7 @@
#include "base/base_switches.h"
#include "base/command_line.h"
+#include "base/metrics/histogram_macros.h"
#include "components/metrics/metrics_pref_names.h"
#include "components/metrics/metrics_service.h"
#include "components/prefs/pref_service.h"
@@ -17,6 +18,13 @@ namespace metrics {
bool MetricsServiceAccessor::IsMetricsReportingEnabled(
PrefService* pref_service) {
#if defined(GOOGLE_CHROME_BUILD)
+ UMA_HISTOGRAM_BOOLEAN("UMA.Dbg.IsMetricsReportingEnabled.ChromeBuild", true);
+ UMA_HISTOGRAM_BOOLEAN("UMA.Dbg.IsMetricsReportingEnabled.PrefValue", pref_service->GetBoolean(prefs::kMetricsReportingEnabled));
+ UMA_HISTOGRAM_BOOLEAN("UMA.Dbg.IsMetricsReportingEnabled.PrefIsManaged", pref_service->IsManagedPreference(prefs::kMetricsReportingEnabled));
+ UMA_HISTOGRAM_BOOLEAN("UMA.Dbg.IsMetricsReportingEnabled.PrefIsManagedByCust", pref_service->IsPreferenceManagedByCustodian(prefs::kMetricsReportingEnabled));
+ UMA_HISTOGRAM_BOOLEAN("UMA.Dbg.IsMetricsReportingEnabled.PrefIsModifiable", pref_service->IsPreferenceManagedByCustodian(prefs::kMetricsReportingEnabled));
+ UMA_HISTOGRAM_BOOLEAN("UMA.Dbg.IsMetricsReportingEnabled.PrefIsSet", pref_service->HasPrefPath(prefs::kMetricsReportingEnabled));
+
// In official builds, disable metrics when reporting field trials are
// forced; otherwise, use the value of the user's preference to determine
// whether to enable metrics reporting.
@@ -24,6 +32,8 @@ bool MetricsServiceAccessor::IsMetricsReportingEnabled(
switches::kForceFieldTrials) &&
pref_service->GetBoolean(prefs::kMetricsReportingEnabled);
#else
+ UMA_HISTOGRAM_BOOLEAN("UMA.Dbg.IsMetricsReportingEnabled.ChromeBuild", false);
+
// In non-official builds, disable metrics reporting completely.
return false;
#endif // defined(GOOGLE_CHROME_BUILD)
« no previous file with comments | « components/metrics/metrics_service.cc ('k') | components/metrics_services_manager/metrics_services_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698