Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 293673004: Remove unused RenderIO() interface. (Closed)

Created:
6 years, 7 months ago by no longer working on chromium
Modified:
6 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove unused RenderIO() interface. BUG=337096 TEST=bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -93 lines) Patch
M content/renderer/media/renderer_webaudiodevice_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/renderer_webaudiodevice_impl.cc View 2 chunks +6 lines, -16 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_device.h View 1 chunk +1 line, -4 lines 0 comments Download
M media/audio/audio_output_device.cc View 5 chunks +5 lines, -28 lines 0 comments Download
M media/audio/audio_output_device_unittest.cc View 5 chunks +9 lines, -32 lines 0 comments Download
M media/base/audio_renderer_sink.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
no longer working on chromium
Hi Dale, this should be the last piece of chromium code about the unified IO. ...
6 years, 7 months ago (2014-05-19 19:32:18 UTC) #1
DaleCurtis
lgtm
6 years, 7 months ago (2014-05-19 19:38:43 UTC) #2
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-19 19:42:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/293673004/1
6 years, 7 months ago (2014-05-19 19:42:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 21:41:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 22:20:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28582)
6 years, 7 months ago (2014-05-19 22:20:01 UTC) #7
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-20 00:47:41 UTC) #8
DaleCurtis
Note there's still one more piece: AudioParameters::input_channels().
6 years, 7 months ago (2014-05-20 00:47:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/293673004/1
6 years, 7 months ago (2014-05-20 00:48:18 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 02:19:52 UTC) #11
Message was sent while issue was closed.
Change committed as 271536

Powered by Google App Engine
This is Rietveld 408576698