Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoaderTypes.h

Issue 2936723002: Report frequency of single page app navigations to UMA (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoaderTypes.h
diff --git a/third_party/WebKit/Source/core/loader/FrameLoaderTypes.h b/third_party/WebKit/Source/core/loader/FrameLoaderTypes.h
index 97a514633ff62dd8ebcc23a2041c7031821d797b..b4621f49c745db88fa082534f75bf7de665465d8 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoaderTypes.h
+++ b/third_party/WebKit/Source/core/loader/FrameLoaderTypes.h
@@ -32,14 +32,18 @@
namespace blink {
// See WebFrameLoadType in public/web/WebFrameLoadType.h for details.
+// These values are used for UMA histogram. New enum values can be added, but
+// existing enums must never be renumbered or deleted and reused.
enum FrameLoadType {
- kFrameLoadTypeStandard,
- kFrameLoadTypeBackForward,
- kFrameLoadTypeReload,
- kFrameLoadTypeReplaceCurrentItem,
- kFrameLoadTypeInitialInChildFrame,
- kFrameLoadTypeInitialHistoryLoad,
- kFrameLoadTypeReloadBypassingCache,
+ kFrameLoadTypeStandard = 0,
+ kFrameLoadTypeBackForward = 1,
+ kFrameLoadTypeReload = 2,
+ kFrameLoadTypeReplaceCurrentItem = 3,
+ kFrameLoadTypeInitialInChildFrame = 4,
+ kFrameLoadTypeInitialHistoryLoad = 5,
+ kFrameLoadTypeReloadBypassingCache = 6,
+ // kFrameLoadTypeCount is just a placeholder to indicate the count of types.
+ kFrameLoadTypeCount
tdresser 2017/06/12 20:54:19 I think kFrameLoadTypeLast = kFrameLoadTypeReload
Liquan (Max) Gu 2017/06/12 21:51:31 Yes it does. Thanks!
};
enum NavigationType {
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698