Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/core/loader/FrameLoaderTypes.h

Issue 2936723002: Report frequency of single page app navigations to UMA (Closed)
Patch Set: move enum to header Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 kScrollRestorationManual 94 kScrollRestorationManual
95 }; 95 };
96 96
97 enum class ProgressBarCompletion { 97 enum class ProgressBarCompletion {
98 kLoadEvent, 98 kLoadEvent,
99 kResourcesBeforeDCL, 99 kResourcesBeforeDCL,
100 kDOMContentLoaded, 100 kDOMContentLoaded,
101 kResourcesBeforeDCLAndSameOriginIFrames 101 kResourcesBeforeDCLAndSameOriginIFrames
102 }; 102 };
103 103
104 // This enum is used to index different kinds of single-page-application
105 // navigations for UMA enum histogram. New enum values can be added, but
106 // existing enums must never be renumbered or deleted and reused.
107 // This enum should be consistent with SinglePageAppNavigationType in
108 // tools/metrics/histograms/enums.
tdresser 2017/06/26 15:12:50 nit: /enums.xml
Liquan (Max) Gu 2017/06/26 15:45:11 Done.
109 enum SinglePageAppNavigationType {
110 kSPANavTypeHistoryPushStateOrReplaceState = 0,
111 kSPANavTypeSameDocumentBackwardOrForward = 1,
112 kSPANavTypeOtherFragmentNavigation = 2,
113 kSPANavTypeCount
114 };
104 } // namespace blink 115 } // namespace blink
105 116
106 #endif 117 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698