Report frequency of single page app navigations to UMA

third_party/WebKit/Source/core/loader/FrameLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) Research In Motion Limited 2009. All rights reserved.
  * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>
  * Copyright (C) 2011 Google Inc. All rights reserved.
@@ skipping 61 matching lines @@
 #include "core/loader/ProgressTracker.h"
 #include "core/loader/appcache/ApplicationCacheHost.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/CreateWindow.h"
 #include "core/page/FrameTree.h"
 #include "core/page/Page.h"
 #include "core/page/scrolling/ScrollingCoordinator.h"
 #include "core/probe/CoreProbes.h"
 #include "core/svg/graphics/SVGImage.h"
 #include "core/xml/parser/XMLDocumentParser.h"
+#include "platform/Histogram.h"
 #include "platform/InstanceCounters.h"
 #include "platform/PluginScriptForbiddenScope.h"
 #include "platform/ScriptForbiddenScope.h"
 #include "platform/bindings/DOMWrapperWorld.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "platform/loader/fetch/ResourceFetcher.h"
 #include "platform/loader/fetch/ResourceRequest.h"
 #include "platform/network/HTTPParsers.h"
 #include "platform/network/NetworkUtils.h"
 #include "platform/scroll/ScrollAnimatorBase.h"
@@ skipping 385 matching lines @@
   return allowed;
 }
 
 void FrameLoader::UpdateForSameDocumentNavigation(
     const KURL& new_url,
     SameDocumentNavigationSource same_document_navigation_source,
     PassRefPtr<SerializedScriptValue> data,
     HistoryScrollRestorationType scroll_restoration_type,
     FrameLoadType type,
     Document* initiating_document) {
+  // This enum is used to index different kinds of single-page-application
+  // navigations for UMA enum histogram. New enum values can be added, but
+  // existing enums must never be renumbered or deleted and reused.
+  // This enum should be consistent with SinglePageAppNavigationType in
+  // tools/metrics/histograms/enums.
+  enum SinglePageAppNavigationType {
+    kSPANavTypeHistoryPushStateOrReplaceState = 0,
+    kSPANavTypeSameDocumentBackwardOrForward = 1,
+    kSPANavTypeOtherFragmentNavigation = 2,
+    kSPANavTypeCount = kSPANavTypeOtherFragmentNavigation + 1,
+  };
+  const char* histogramName =
+      "RendererScheduler.UpdateForSameDocumentNavigationCount";
+  if (same_document_navigation_source == kSameDocumentNavigationHistoryApi) {

[Liquan (Max) Gu, 2017/06/16 17:37:35]

Can I assume that these three conditions are exclusive and there is no such
situation where (source == kSameDocumentNavigationHistoryApi && type ==
kFrameLoadTypeBackForward)

+    UMA_HISTOGRAM_ENUMERATION(histogramName,
+                              kSPANavTypeHistoryPushStateOrReplaceState,
+                              kSPANavTypeCount);
+  }
+  if (type == kFrameLoadTypeBackForward) {
+    UMA_HISTOGRAM_ENUMERATION(histogramName,
+                              kSPANavTypeSameDocumentBackwardOrForward,
+                              kSPANavTypeCount);
+  }
+  if (same_document_navigation_source == kSameDocumentNavigationDefault &&
+      type != kFrameLoadTypeBackForward) {
+    UMA_HISTOGRAM_ENUMERATION(histogramName, kSPANavTypeOtherFragmentNavigation,
+                              kSPANavTypeCount);
+  }
+
   TRACE_EVENT1("blink", "FrameLoader::updateForSameDocumentNavigation", "url",
                new_url.GetString().Ascii().data());
 
   // Generate start and stop notifications only when loader is completed so that
   // we don't fire them for fragment redirection that happens in window.onload
   // handler. See https://bugs.webkit.org/show_bug.cgi?id=31838
   // Do not fire the notifications if the frame is concurrently navigating away
   // from the document, since a new document is already loading.
   if (frame_->GetDocument()->LoadEventFinished() &&
       !provisional_document_loader_)
@@ skipping 1187 matching lines @@
   // TODO(japhet): This is needed because the browser process DCHECKs if the
   // first entry we commit in a new frame has replacement set. It's unclear
   // whether the DCHECK is right, investigate removing this special case.
   bool replace_current_item = load_type == kFrameLoadTypeReplaceCurrentItem &&
                               (!Opener() || !request.Url().IsEmpty());
   loader->SetReplacesCurrentHistoryItem(replace_current_item);
   return loader;
 }
 
 }  // namespace blink