Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2936693002: Reapply "Separate out loop closure information." (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Separate out loop closure information." This reverts commit d85512e0add0be36385f2f13306f038fc9316188. BUG= Committed: https://github.com/dart-lang/sdk/commit/32e0be82ff3be27934c84f9b0534bec4d30bb20e

Patch Set 1 #

Patch Set 2 : call with ast.node instead of ir.Node until we update that path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -64 lines) Patch
M pkg/compiler/lib/src/closure.dart View 6 chunks +48 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 9 chunks +48 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 9 chunks +56 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 4 chunks +22 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/ssa/loop_handler.dart View 8 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Emily Fortuna
TBR -- (Siggi's out today). You only need to look at the diff between patchset ...
3 years, 6 months ago (2017-06-12 21:54:34 UTC) #2
Emily Fortuna
Committed patchset #2 (id:20001) manually as 32e0be82ff3be27934c84f9b0534bec4d30bb20e (presubmit successful).
3 years, 6 months ago (2017-06-12 21:55:23 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-06-13 09:10:00 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698