Issue 2936683002: Revert "Separate out loop closure information."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2936683002: Revert "Separate out loop closure information." (Closed)

Created:
3 years, 6 months ago by Emily Fortuna

Modified:
3 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Separate out loop closure information." This reverts commit 5636a225d7a2f49136fb336c26f6f7f479800129. BUG= Committed: https://github.com/dart-lang/sdk/commit/d85512e0add0be36385f2f13306f038fc9316188

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -185 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	6 chunks	+3 lines, -48 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	9 chunks	+11 lines, -48 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View	9 chunks	+14 lines, -55 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/locals_handler.dart	View	4 chunks	+22 lines, -22 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/loop_handler.dart	View	8 chunks	+14 lines, -6 lines	0 comments	Download

Total messages: 4 (2 generated)

Emily Fortuna

TBR some Kernel tests are failing -- reverting to understand the issue.

3 years, 6 months ago (2017-06-12 18:00:56 UTC) #2

Emily Fortuna

3 years, 6 months ago (2017-06-12 18:01:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d85512e0add0be36385f2f13306f038fc9316188 (presubmit successful).