Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/extensions/extension_bindings_apitest.cc

Issue 2936673004: Revert of [Extensions Bindings] Avoid passing the event filter to JS (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/bindings/event_filter/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_bindings_apitest.cc
diff --git a/chrome/browser/extensions/extension_bindings_apitest.cc b/chrome/browser/extensions/extension_bindings_apitest.cc
index 3b15f0f5d7a80c74af366af2b562060620c07393..b090c840059349e9b2cea4903dacb98ac094cae7 100644
--- a/chrome/browser/extensions/extension_bindings_apitest.cc
+++ b/chrome/browser/extensions/extension_bindings_apitest.cc
@@ -17,7 +17,6 @@
#include "extensions/browser/process_manager.h"
#include "extensions/test/extension_test_message_listener.h"
#include "extensions/test/result_catcher.h"
-#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
namespace extensions {
@@ -27,9 +26,6 @@
public:
void SetUpOnMainThread() override {
ExtensionApiTest::SetUpOnMainThread();
- host_resolver()->AddRule("*", "127.0.0.1");
- ASSERT_TRUE(StartEmbeddedTestServer());
-
content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE,
base::BindOnce(&chrome_browser_net::SetUrlRequestMocksEnabled, true));
@@ -121,6 +117,8 @@
}
IN_PROC_BROWSER_TEST_F(ExtensionBindingsApiTest, NoExportOverriding) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
// We need to create runtime bindings in the web page. An extension that's
// externally connectable will do that for us.
ASSERT_TRUE(LoadExtension(
@@ -143,6 +141,8 @@
}
IN_PROC_BROWSER_TEST_F(ExtensionBindingsApiTest, NoGinDefineOverriding) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
// We need to create runtime bindings in the web page. An extension that's
// externally connectable will do that for us.
ASSERT_TRUE(LoadExtension(
@@ -167,6 +167,7 @@
}
IN_PROC_BROWSER_TEST_F(ExtensionBindingsApiTest, HandlerFunctionTypeChecking) {
+ ASSERT_TRUE(embedded_test_server()->Start());
ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL(
@@ -186,6 +187,8 @@
IN_PROC_BROWSER_TEST_F(ExtensionBindingsApiTest,
MoreNativeFunctionInterceptionTests) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
// We need to create runtime bindings in the web page. An extension that's
// externally connectable will do that for us.
ASSERT_TRUE(
@@ -242,6 +245,7 @@
// Load the web page which tries to impersonate the sender extension via
// scripting iframes/child windows before they finish navigating to pages
// within the sender extension.
+ ASSERT_TRUE(embedded_test_server()->Start());
ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL(
@@ -267,6 +271,7 @@
}
IN_PROC_BROWSER_TEST_F(ExtensionBindingsApiTest, TestFreezingChrome) {
+ ASSERT_TRUE(embedded_test_server()->Start());
ui_test_utils::NavigateToURL(
browser(), embedded_test_server()->GetURL(
"/extensions/api_test/bindings/freeze.html"));
@@ -275,18 +280,5 @@
ASSERT_FALSE(web_contents->IsCrashed());
}
-// Tests interaction with event filter parsing.
-IN_PROC_BROWSER_TEST_F(ExtensionBindingsApiTest, TestEventFilterParsing) {
- ExtensionTestMessageListener listener("ready", false);
- ASSERT_TRUE(
- LoadExtension(test_data_dir_.AppendASCII("bindings/event_filter")));
- ASSERT_TRUE(listener.WaitUntilSatisfied());
-
- ResultCatcher catcher;
- ui_test_utils::NavigateToURL(
- browser(), embedded_test_server()->GetURL("example.com", "/title1.html"));
- ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
-}
-
} // namespace
} // namespace extensions
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/bindings/event_filter/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698