Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: net/spdy/chromium/spdy_test_util_common.h

Issue 2936663002: Simplify CombineFrames() interface. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/chromium/spdy_test_util_common.h
diff --git a/net/spdy/chromium/spdy_test_util_common.h b/net/spdy/chromium/spdy_test_util_common.h
index be5f42945c89cdf1a9772faf5813eefa4c9291c5..88ef88acf156e41104df142dc190b1034303ec6d 100644
--- a/net/spdy/chromium/spdy_test_util_common.h
+++ b/net/spdy/chromium/spdy_test_util_common.h
@@ -92,10 +92,8 @@ MockRead CreateMockRead(const SpdySerializedFrame& resp, int seq, IoMode mode);
// Combines the given SpdySerializedFrame into the given char array and returns
// the total length.
Zhongyi Shi 2017/06/12 19:34:12 Could you update the comments since the return typ
Bence 2017/06/12 19:49:13 Oops, sorry about that. Good catch!
-int CombineFrames(const SpdySerializedFrame** frames,
- int num_frames,
- char* buf,
- int buf_len);
+SpdySerializedFrame CombineFrames(
+ std::vector<const SpdySerializedFrame*> frames);
// Returns the SpdyPriority embedded in the given frame. Returns true
// and fills in |priority| on success.

Powered by Google App Engine
This is Rietveld 408576698