[Metrics] Move MetricsServiceObserver into //components/metrics

[Metrics] Move MetricsServiceObserver into //components/metrics

BUG=374204
TEST=compiles
R=asvitkine@chromium.org, blundell@chromium.org
TBR=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271639

[blundell, 2014-05-19 12:12:06]

LGTM

https://codereview.chromium.org/293663002/diff/1/components/metrics/metrics_s...
File components/metrics/metrics_service_observer.h (left):

https://codereview.chromium.org/293663002/diff/1/components/metrics/metrics_s...
components/metrics/metrics_service_observer.h:10: // MetricsServiceObserver
receives notifications from MetricsService.
Could you file a bug if we don't already have one for moving all code in the
metrics component into the ::metrics namespace when the componentization is
done? (It's not worth doing it as we go since there would be a lot of churn over
code that is due to be moved a little later).

[Alexei Svitkine (slow), 2014-05-19 12:12:37]

LGTM

[Ilya Sherman, 2014-05-19 12:15:38]

https://codereview.chromium.org/293663002/diff/1/components/metrics/metrics_s...
File components/metrics/metrics_service_observer.h (left):

https://codereview.chromium.org/293663002/diff/1/components/metrics/metrics_s...
components/metrics/metrics_service_observer.h:10: // MetricsServiceObserver
receives notifications from MetricsService.
On 2014/05/19 12:12:06, blundell wrote:
> Could you file a bug if we don't already have one for moving all code in the
> metrics component into the ::metrics namespace when the componentization is
> done? (It's not worth doing it as we go since there would be a lot of churn
over
> code that is due to be moved a little later).

Good call.  Filed http://crbug.com/374763

[Ilya Sherman, 2014-05-19 12:17:53]

Lei, TBRing you for a trivial refactoring change to
//chrome/browser/chrome_browser_metrics_service_observer.h.

[Ilya Sherman, 2014-05-19 12:17:56]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-05-19 12:18:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/293663002/1

[commit-bot: I haz the power, 2014-05-19 14:09:22]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-19 15:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 15:15:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Ilya Sherman, 2014-05-19 15:16:01]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-05-19 15:16:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/293663002/1

[commit-bot: I haz the power, 2014-05-19 15:25:27]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-19 15:28:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 15:28:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Ilya Sherman, 2014-05-19 16:31:17]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-05-19 16:32:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/293663002/20001

[commit-bot: I haz the power, 2014-05-19 18:54:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 18:54:04]

Failed to apply patch for chrome/browser/metrics/metrics_service.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/metrics/metrics_service.h
  Hunk #1 FAILED at 23.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/metrics/metrics_service.h.rej

Patch:       chrome/browser/metrics/metrics_service.h
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h
b/chrome/browser/metrics/metrics_service.h
index
9a52d030de221a0be1d42ef921d280c8967ef13e..dc3bb2c146828544100fc0f65721a2adb855d333
100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -23,10 +23,10 @@
 #include "base/threading/thread_checker.h"
 #include "base/time/time.h"
 #include "chrome/browser/metrics/metrics_log.h"
-#include "chrome/browser/metrics/metrics_service_observer.h"
 #include "chrome/browser/metrics/tracking_synchronizer_observer.h"
 #include "chrome/common/metrics/metrics_service_base.h"
 #include "chrome/installer/util/google_update_settings.h"
+#include "components/metrics/metrics_service_observer.h"
 #include "content/public/browser/browser_child_process_observer.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"

[Lei Zhang, 2014-05-19 19:09:45]

lgtm

[Ilya Sherman, 2014-05-20 08:19:43]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-05-20 08:20:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/293663002/40001

[commit-bot: I haz the power, 2014-05-20 14:50:20]

Change committed as 271639