Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2936623002: Implement dumb URLLoader{Factory} for ServiceWorker script loading (for try)

Created:
3 years, 6 months ago by kinuko
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, kinuko+serviceworker, nhiroki, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, darin (slow to review), blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement dumb URLLoader{Factory} for ServiceWorker script loading BUG=715640

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased on top of shimazu's patch #

Patch Set 4 : fix #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+979 lines, -515 lines) Patch
M content/browser/background_sync/background_sync_manager_unittest.cc View 1 2 2 chunks +23 lines, -0 lines 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.cc View 1 2 4 chunks +33 lines, -10 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 1 2 5 chunks +12 lines, -3 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 2 7 chunks +14 lines, -15 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 2 24 chunks +77 lines, -32 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 2 7 chunks +8 lines, -9 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 2 10 chunks +18 lines, -21 lines 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler_unittest.cc View 1 2 2 chunks +10 lines, -12 lines 0 comments Download
M content/browser/service_worker/link_header_support_unittest.cc View 1 2 2 chunks +9 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 2 3 4 6 chunks +18 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 2 8 chunks +35 lines, -20 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 1 2 3 chunks +10 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 2 3 4 5 chunks +19 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 2 7 chunks +18 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 2 4 chunks +9 lines, -89 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 2 5 chunks +23 lines, -72 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 2 10 chunks +117 lines, -34 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 2 8 chunks +41 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 3 10 chunks +254 lines, -23 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_registration_handle.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_test_utils.h View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_test_utils.cc View 1 2 3 chunks +20 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_url_loader_job.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_loader_job.cc View 1 2 2 chunks +11 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 2 4 chunks +13 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 2 3 chunks +14 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 5 chunks +16 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 2 3 chunks +16 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 1 2 5 chunks +8 lines, -14 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 1 2 3 4 chunks +7 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.h View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 1 2 3 chunks +23 lines, -10 lines 0 comments Download
M content/common/service_worker/embedded_worker.mojom View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M content/common/service_worker/service_worker.mojom View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/service_worker/service_worker_provider.mojom View 1 2 3 2 chunks +19 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.mojom View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.typemap View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_instance_client_impl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_instance_client_impl.cc View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 2 5 chunks +7 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 6 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 30 (30 generated)
kinuko
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-15 06:35:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936623002/20001
3 years, 6 months ago (2017-06-15 06:35:13 UTC) #2
kinuko
Description was changed from ========== Implement dumb URLLoader{Factory} for ServiceWorker script loading BUG=715640 ========== to ...
3 years, 6 months ago (2017-06-15 06:35:20 UTC) #3
kinuko
The CQ bit was unchecked by kinuko@chromium.org
3 years, 6 months ago (2017-06-15 06:40:44 UTC) #4
kinuko
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-15 08:17:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936623002/40001
3 years, 6 months ago (2017-06-15 08:17:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-15 09:28:22 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/318136)
3 years, 6 months ago (2017-06-15 09:28:24 UTC) #8
kinuko
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-15 14:35:27 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936623002/60001
3 years, 6 months ago (2017-06-15 14:35:42 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-15 15:30:03 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/250741)
3 years, 6 months ago (2017-06-15 15:30:03 UTC) #12
kinuko
Patchset #4 (id:60001) has been deleted
3 years, 6 months ago (2017-06-15 20:45:26 UTC) #13
kinuko
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-15 20:46:49 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936623002/80001
3 years, 6 months ago (2017-06-15 20:47:21 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-15 21:41:52 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/318641)
3 years, 6 months ago (2017-06-15 21:41:53 UTC) #17
kinuko
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 06:02:46 UTC) #18
kinuko
Patchset #4 (id:80001) has been deleted
3 years, 6 months ago (2017-06-16 06:02:54 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936623002/100001
3 years, 6 months ago (2017-06-16 06:03:09 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-16 06:39:02 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/390594)
3 years, 6 months ago (2017-06-16 06:39:03 UTC) #22
kinuko
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 08:53:54 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936623002/120001
3 years, 6 months ago (2017-06-16 08:54:09 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-16 09:42:53 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/480688)
3 years, 6 months ago (2017-06-16 09:42:54 UTC) #26
kinuko
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 14:52:42 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936623002/120001
3 years, 6 months ago (2017-06-16 14:53:04 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-16 16:27:26 UTC) #29
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 16:27:27 UTC) #30 
Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698