Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 293643002: Use special icon for shared folders in file list. (Closed)

Created:
6 years, 7 months ago by fukino
Modified:
6 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Use special icon for shared folders in file list. Add css class 'shared' for shared folders in file list (FileTable and FileGrid). Use special icon for folders which has a class 'shared'. BUG=264812 TEST=manually confirmed Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271371

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use classList.toggle(). #

Patch Set 3 : Remove curly bracket from one-line if statements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_types.css View 2 chunks +20 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_grid.js View 2 chunks +8 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_table.js View 1 2 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fukino
yoshiki san, could you take a look? Showing shared folder in DirectoryTree seems to need ...
6 years, 7 months ago (2014-05-19 11:00:43 UTC) #1
yoshiki
lgtm with nit https://codereview.chromium.org/293643002/diff/1/ui/file_manager/file_manager/foreground/js/file_table.js File ui/file_manager/file_manager/foreground/js/file_table.js (right): https://codereview.chromium.org/293643002/diff/1/ui/file_manager/file_manager/foreground/js/file_table.js#newcode833 ui/file_manager/file_manager/foreground/js/file_table.js:833: iconDiv.classList.add('shared'); nit: you can use: iconDiv.classList.toggle('shared', ...
6 years, 7 months ago (2014-05-19 11:26:23 UTC) #2
fukino
https://codereview.chromium.org/293643002/diff/1/ui/file_manager/file_manager/foreground/js/file_table.js File ui/file_manager/file_manager/foreground/js/file_table.js (right): https://codereview.chromium.org/293643002/diff/1/ui/file_manager/file_manager/foreground/js/file_table.js#newcode833 ui/file_manager/file_manager/foreground/js/file_table.js:833: iconDiv.classList.add('shared'); On 2014/05/19 11:26:23, yoshiki wrote: > nit: you ...
6 years, 7 months ago (2014-05-19 11:38:10 UTC) #3
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-05-19 11:45:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/293643002/30001
6 years, 7 months ago (2014-05-19 11:45:35 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 13:24:28 UTC) #6
Message was sent while issue was closed.
Change committed as 271371

Powered by Google App Engine
This is Rietveld 408576698