third_party/WebKit/public/web/WebFrame.h - Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame. (Closed)

Patch Set: Added TODOs as suggested by dcheng@ (this patchset also accidentally includes a rebase...). Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebFrame.h

diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h

index 394d190b59e3beb40c3f7dce641dec7abf8197e5..c8f3a3a481a2465a26bd6002a7fafa3c8cc1b36a 100644

--- a/third_party/WebKit/public/web/WebFrame.h

+++ b/third_party/WebKit/public/web/WebFrame.h

@@ -140,10 +140,6 @@ class BLINK_EXPORT WebFrame {

// NOTE: These routines do not force page layout so their results may

// not be accurate if the page layout is out-of-date.

- // The scroll offset from the top-left corner of the frame in pixels.

- virtual WebSize GetScrollOffset() const = 0;

- virtual void SetScrollOffset(const WebSize&) = 0;

// The size of the contents area.

virtual WebSize ContentsSize() const = 0;