third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp - Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp

Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame. (Closed)

Patch Set: Added TODOs as suggested by dcheng@ (this patchset also accidentally includes a rebase...). Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp b/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp

index 26cdc980b6e4174121c1bd68505238edfb7ac9eb..5d9ed2a0ff7a59b3a8af17acd82716661355acc0 100644

--- a/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp

@@ -53,7 +53,7 @@ TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithScale) {

loader.GetDocumentLoader()->SetLoadType(kFrameLoadTypeBackForward);

web_view->SetPageScaleFactor(3.0f);

- web_view->MainFrame()->SetScrollOffset(WebSize(0, 500));

+ web_view->MainFrameImpl()->SetScrollOffset(WebSize(0, 500));

loader.GetDocumentLoader()->GetInitialScrollState().was_scrolled_by_user =

false;

loader.GetDocumentLoader()->GetHistoryItem()->SetPageScaleFactor(2);