third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 6f75a156113a454ed6709f14b16412825f297e50..d7df1f0644b92a2c30d3937bf0f40d3684bed0f4 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -1296,8 +1296,8 @@ WebRect WebViewImpl::WidenRectWithinPageBounds(const WebRect& source,

if (MainFrame())

max_size = MainFrame()->ContentsSize();

IntSize scroll_offset;

- if (MainFrame())

- scroll_offset = MainFrame()->GetScrollOffset();

+ if (MainFrame() && MainFrame()->IsWebLocalFrame())

+ scroll_offset = MainFrame()->ToWebLocalFrame()->GetScrollOffset();

dcheng 2017/06/16 00:03:41 Ditto.

Łukasz Anforowicz 2017/06/16 21:28:13 Done.

int left_margin = target_margin;

int right_margin = target_margin;