Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: third_party/WebKit/public/web/WebFrame.h

Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame. (Closed)
Patch Set: Use WebViewHelper::LocalMainFrame() where possible. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 // another process and it dynamically updates these properties. 133 // another process and it dynamically updates these properties.
134 // TODO(dcheng): Currently, the update only takes effect on next frame 134 // TODO(dcheng): Currently, the update only takes effect on next frame
135 // navigation. This matches the in-process frame behavior. 135 // navigation. This matches the in-process frame behavior.
136 void SetFrameOwnerProperties(const WebFrameOwnerProperties&); 136 void SetFrameOwnerProperties(const WebFrameOwnerProperties&);
137 137
138 // Geometry ----------------------------------------------------------- 138 // Geometry -----------------------------------------------------------
139 139
140 // NOTE: These routines do not force page layout so their results may 140 // NOTE: These routines do not force page layout so their results may
141 // not be accurate if the page layout is out-of-date. 141 // not be accurate if the page layout is out-of-date.
142 142
143 // The scroll offset from the top-left corner of the frame in pixels.
144 virtual WebSize GetScrollOffset() const = 0;
145 virtual void SetScrollOffset(const WebSize&) = 0;
146
147 // The size of the contents area. 143 // The size of the contents area.
148 virtual WebSize ContentsSize() const = 0; 144 virtual WebSize ContentsSize() const = 0;
149 145
150 // Returns true if the contents (minus scrollbars) has non-zero area. 146 // Returns true if the contents (minus scrollbars) has non-zero area.
151 virtual bool HasVisibleContent() const = 0; 147 virtual bool HasVisibleContent() const = 0;
152 148
153 // Returns the visible content rect (minus scrollbars, in absolute coordinate) 149 // Returns the visible content rect (minus scrollbars, in absolute coordinate)
154 virtual WebRect VisibleContentRect() const = 0; 150 virtual WebRect VisibleContentRect() const = 0;
155 151
156 // Whether to collapse the frame's owner element in the embedder document, 152 // Whether to collapse the frame's owner element in the embedder document,
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 WebFrame* first_child_; 292 WebFrame* first_child_;
297 WebFrame* last_child_; 293 WebFrame* last_child_;
298 294
299 WebFrame* opener_; 295 WebFrame* opener_;
300 std::unique_ptr<OpenedFrameTracker> opened_frame_tracker_; 296 std::unique_ptr<OpenedFrameTracker> opened_frame_tracker_;
301 }; 297 };
302 298
303 } // namespace blink 299 } // namespace blink
304 300
305 #endif 301 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698